test: push Effect aggregate coverage from 84% to 87%#59
Merged
Conversation
…del Create+ToString paths
CI's Release config initializes the JSON serializer's PropertyNamingPolicy to camelCase, but local dev runs without that wiring produced PascalCase output. The point of the assertions was to exercise ToString(); the specific property-name casing is irrelevant.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remaining ~13% gap is concentrated in RabbitMQ broadcaster (~175 lines, needs a real broker / testcontainers) and Postgres-backed DataContext logging providers (~78 lines, needs Postgres CI), neither of which fits inside the existing InMemory test setup.
Test plan