Conversation
…Memory and RabbitMQ broadcaster against a real broker Two new test files: - DataContextLoggingProviderTests exercises every branch of DataContextLogger (level filter, EF.Database.Command short-circuit, exact + wildcard blacklist, IsEnabled, BeginScope) and the provider's blacklist construction, CreateLogger configuration, FlushLoopAsync batching against InMemory, and double-Dispose safety. - RabbitMqBroadcasterIntegrationTests stands up RabbitMqTrainEventBroadcaster + RabbitMqTrainEventReceiver against a real broker, covering round-trip publish/receive, channel reuse on repeated publishes, handler-throws / Nack-and-keep-consuming, and Stop/Dispose cleanup paths. CI pull_request and nuget_release workflows now provision a rabbitmq:3 service container alongside postgres so the broadcaster suite runs in CI. Local development uses the docker-compose RabbitMQ on amqp://guest:guest@localhost:5672/. Local line coverage on Trax.Effect aggregate moves from 86.7% to 94.8%.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the two biggest remaining gaps that needed infrastructure:
Infra
CI pull_request and nuget_release workflows now provision a `rabbitmq:3` service container alongside postgres. Local dev uses the docker-compose RabbitMQ on `amqp://guest:guest@localhost:5672/`.
Numbers
Local line coverage on Trax.Effect aggregate moves from 86.7% to 94.8%.
Test plan