Merged
Conversation
ConnectionFailure_RetriesInsteadOfCrashing previously slept a fixed 7 seconds hoping the 5-second retry delay had fired by then. Polls for callCount > 1 with a 15-second ceiling so the test reflects the service's real retry timing rather than racing GitHub Actions scheduling overhead. FlushLoop_BatchesLogsToDatabase previously slept 1.5s past the 1-second flush timer. Polls the database for the first persisted log with a 15-second ceiling. Local run drops from 1.5s+ to roughly 600ms.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing tests had fixed-duration sleeps standing in for synchronisation:
ConnectionFailure_RetriesInsteadOfCrashingpreviously slept 7s hoping the 5s retry delay had fired by then. Now polls forcallCount > 1with a 15s ceiling, so the test reflects the service's real retry timing rather than racing GitHub Actions scheduling overhead.FlushLoop_BatchesLogsToDatabasepreviously slept 1.5s past the 1-second flush timer. Now polls the database for the first persisted log with a 15s ceiling. Local run drops from 1.5s+ to ~600ms.Both timeouts are safety ceilings, not sleeps. Each test finishes as soon as the underlying signal appears.
Test plan
dotnet build— zero warnings (one pre-existing CS8602 in JsonEffectProviderTests unrelated to this change)dotnet csharpier check .— clean