test: raise coverage above 95% with ServiceTrain and model gap tests#65
Merged
Conversation
Adds tests for: - ServiceTrain Left+OperationCanceled branch (junction-thrown OCE caught by default RunInternal) and the inner OnCancelled hook-throw path - Output serialization fallback when SaveTrainParameters is not configured - ServiceTrainExtensions Pending-state guard - Manifest.Create with a null FullName Type, NameType resolution via loaded-assembly fallback, and unresolvable-type TypeLoadException - Metadata.AddException JSON-deserialization branch (Priority 2) - JunctionMetadata Create + ToString - ParameterEffect ObjectDisposedException fallback for Input and Output - ValueTupleConverter Read path - InjectProperties IEnumerable<T> branch - AddJunctionEffect / AddLifecycleHook resolution of all registered interfaces - TrainEventReceiverService retry path with throwing StopAsync
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceTrain(Left+OCE, output serialization fallback),ServiceTrainExtensionsPending-state guard,ManifestCreate/NameType edge cases,Metadata.AddExceptionJSON-deserialization,JunctionMetadataCreate/ToString,ParameterEffectObjectDisposed fallback,ValueTupleConverter.Read,InjectPropertiesIEnumerable branch, factory delegate resolution inAddJunctionEffect/AddLifecycleHook, andTrainEventReceiverServiceretry-with-throwing-StopAsync.Test plan
dotnet buildclean (zero warnings)dotnet testall green across all five test projects (629 tests)dotnet csharpier check .clean