fix: use dedicated rabbitmq user for CI service container#68
Merged
Conversation
Default 'guest' user is restricted to localhost in RabbitMQ. GitHub Actions service containers route through port forwarding so the broker sees connections as non-localhost and rejects guest. Override with a dedicated trax/trax123 user, mirroring the Postgres convention, and update broadcaster tests to match.
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.35.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guestuser is restricted to localhost, so broadcaster integration tests connect with rejected creds.pull_request.ymlandnuget_release.ymlto a dedicatedtrax/trax123user, matching the Postgres pattern, and bump the image torabbitmq:4-management.Test plan
RabbitMqBroadcasterIntegrationTestsandBroadcasterRegistrationTestsstill pass