Merged
Conversation
…eServer) Add unit tests for the JobHunt junctions that previously had 0% coverage (RefetchAndHashJunction, FanOutCompanyMonitorJunction, FanOutMonitorJunction) covering the missing-job, no-URL, scrape-success, scrape-404, and scrape-failure paths plus the FanOut aggregation logic. Add tests for the StubEmailSender and ManualContactProvider stubs, the BuildProjectJunction skip-build path, the ExecuteTestsJunction missing-DLL guard, and additional JobHuntLifecycleHook scenarios (MonitorJob notifications, both-id and single-id topic routing, PascalCase property fallback). Note: GameServer.E2E has 5 pre-existing failures on main that are unrelated to this change. Coverage was measured with that suite excluded to isolate the diff impact.
|
This PR is included in version 1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
dotnet testpasses locally