ci: add postgres and rabbitmq services to release workflow#52
Merged
Conversation
Release runs were failing in JobHunt.E2E because the workflow had no Postgres available, so DatabaseMigrator.Migrate() couldn't open a connection. PR builds already wire up both services; mirror the same setup in nuget_release.yml so coverage uploads to Codecov on main.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.21.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OneTimeSetUpcouldn't migrate the DB and 30 tests failed at connect time. The test step exited 1, which caused Codecov to never get a successful upload on main (Codecov shows the repo as activated but withtotals: null).pull_request.yml:postgres:17+rabbitmq:4-managementwith healthchecks, plus a step to create the per-suite databases (trax_e2e_tests,chat_e2e_tests,energyhub_e2e_tests,jobhunt_e2e_tests).Test plan
Trax.Samples.JobHunt.E2EandTrax.Samples.EnergyHub.E2E.TraxSharp/Trax.Samplesafter the run completes.