fix(persisted-operations sample): demo a genuinely different hot-fix doc#56
Merged
Merged
Conversation
The hot-fix demo re-uploaded the same document text from manifest.json, so it would have passed even if the underlying cache-invalidation path in Trax.Api.GraphQL.PersistedOperations had been silently broken (and in fact it was — see the matching fix in Trax.Api). The client now re-uploads a shape-changed document (adds __typename) with bypassShapeDiff and asserts the new field appears in the response, so the sample fails loudly if HC's IDocumentCache / IPreparedOperationCache are not invalidated on upsert. Also extend POSTGRES_MULTIPLE_DATABASES with the trax_api_* databases the Trax.Api integration tests need; CI creates these out-of-band and local dev was the only place they were missing.
Merged
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.23.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hot-fix demo re-uploaded the same document text from
manifest.json, so it would have passed even if the underlying cache-invalidation path inTrax.Api.GraphQL.PersistedOperationshad been silently broken — and in fact it was, see paired PR TraxSharp/Trax.Api#52. The client now re-uploads a shape-changed document (adds__typenamewithbypassShapeDiff) and asserts the new field appears in the response, so the sample fails loudly if HC'sIDocumentCache/IPreparedOperationCacheare not invalidated on upsert.Also extends
POSTGRES_MULTIPLE_DATABASESindocker-compose.ymlwith thetrax_api_*databases the Trax.Api integration tests need. CI creates these out-of-band; local dev was the only place they were missing.Test plan
dotnet run --project samples/PersistedOperations/Trax.Samples.PersistedOperations.Apithendotnet run --project samples/PersistedOperations/Trax.Samples.PersistedOperations.Clientagainst the paired Trax.Api fix printsHot-fix verified: __typename present in response.Hot-fix did not take effect.docker compose up -don a clean volume creates every database the Trax.Api integration suite needs.Related