fix: improve scheduler startup resilience on low-resource Postgres#43
Merged
Merged
Conversation
Orphan manifest pruning timed out on a 2 vCPU Postgres instance because EF Core inlined 5000+ expected external IDs as NOT IN(...) string parameters, overwhelming the query planner. The fix loads all manifest ID pairs with a lightweight SELECT and computes the orphan set in C#, then deletes in batches of 500 by integer PK. Also batches RecoverStuckJobs via ExecuteUpdateAsync (same pattern as the reap junctions) and adds MaxWorkQueueEntriesPerCycle (default 200) to cap work queue creation per manifest manager cycle.
|
This PR is included in version 1.24.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOT IN(...)string parameters, overwhelming the query planner. The fix loads all manifest ID pairs with a lightweightSELECTand computes the orphan set in C#, then deletes in batches of 500 by integer PK.RecoverStuckJobsnow uses batchedExecuteUpdateAsyncinstead of loading all stuck metadata into memory — matches the reap junction pattern.MaxWorkQueueEntriesPerCycleconfig (default: 200, null = unlimited) caps how many work queue entriesCreateWorkQueueEntriesJunctioncreates per manifest manager cycle, preventing write bursts after extended downtime.PruneStaleManifestsAsyncinTraxSchedulerfor consistency.Test plan
MaxWorkQueueEntriesPerCycle(limit=3 with 10 due, null with 10 due)