Add AddException priority chain tests for exception data preservation#45
Merged
Conversation
…ation Test that Metadata.AddException correctly reads TrainExceptionData from Exception.Data dictionary, falls back to JSON message deserialization, and handles stack trace fallback for backwards compatibility.
|
This PR is included in version 1.25.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata.AddExceptioncorrectly reads fromException.Datadictionary, falls back to JSON message deserialization, and handles stack trace fallbackTest plan
RemoteErrorRoundTripTests— 6 new tests for Exception.Data priority, JSON fallback, stack trace preference, plain exception fallback