feat: mark remote run execution as trusted#48
Merged
Conversation
Wraps the executionService.RunAsync call inside TraxRequestHandler in
ITrustedExecutionScope.BeginTrusted("scheduler.remote-run") so the
mediator's per-train authorization check is skipped for work the
scheduler dispatches. Remote job submissions were already authorized
at the original API submission point; re-checking here would require
carrying the submitter's principal across process boundaries for no
additional safety benefit.
Adjusts the request-handler unit and integration tests to register
the new ITrustedExecutionScope dependency.
|
This PR is included in version 1.27.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executionService.RunAsyncinTraxRequestHandlerwithITrustedExecutionScope.BeginTrusted("scheduler.remote-run")so the mediator's per-train authorization check is skipped for work the scheduler dispatches.ITrustedExecutionScopedependency.Depends on
ITrustedExecutionScope)Test plan
dotnet buildzero warningsTraxRequestHandlerTests(unit) +RemoteRunExecutionTests(integration) green once Mediator package is published withITrustedExecutionScope