test: give each fixture its own Postgres database#52
Merged
Conversation
Three Tests.Integration fixtures (DefaultJobSubmitter, SchedulerBuilderValidation, SchedulerConfigurationBuilderSettings) all migrated and ran against trax_scheduler_tests. NUnit runs fixtures in parallel, so two could enter DatabaseMigrator.Migrate at once, contend on the migrator advisory lock, and one would time out with an Npgsql operation-timeout. We've seen this same class of flake on Trax.Api; pre-empting it here. Split each fixture onto its own DB and have CI psql CREATE DATABASE for each before tests run.
…tests are included in coverage
…cheduler delayed-trigger / typed ScheduleOnce paths
The CREATE DATABASE bootstrap step was connecting via -d trax, but the container's POSTGRES_DB is trax_scheduler_tests, so psql failed with 'database "trax" does not exist'. Switch the bootstrap connection to the seed DB the container actually creates. Per-fixture DBs (and their isolation) are unchanged.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
This PR is included in version 1.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trax_scheduler_default_submitter,trax_scheduler_builder_validation,trax_scheduler_builder_settings).CREATE DATABASEs each before the test run.NUnit runs fixtures in parallel within an assembly. All three were sharing
trax_scheduler_testsand each runsDatabaseMigrator.MigrateinOneTimeSetUp. When two fixtures hit the migrator advisory lock at the same time one can time out with an Npgsql operation-timeout. We saw this on Trax.Api on main; pre-empting it here. Per-DB isolation removes the contention without serializing the suite.Test plan