test: cover JobRunner endpoint lambdas and polling-service loops#54
Merged
test: cover JobRunner endpoint lambdas and polling-service loops#54
Conversation
Two test files added: - JobRunnerEndpointTests stands up a TestServer with UseTraxJobRunner and UseTraxRunEndpoint mapped, then exercises the happy + exception paths of both endpoint lambdas against an NSubstitute ITraxRequestHandler. Adds Microsoft.AspNetCore.TestHost + Microsoft.AspNetCore.Mvc.Testing to the test project. - PollingServicesTests instantiates each of the four scheduler BackgroundServices (ManifestManager, JobDispatcher, MetadataCleanup, DeadLetterCleanup) with a mock service-provider chain and verifies the immediate-cycle behavior, train-throw resilience, and the JobDispatcherEnabled=false skip path. Covers the 200 lines of endpoint + polling-service loops that previously had no direct test coverage. Local line coverage on Trax.Scheduler moves from 88.7% to 91.7%.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test files added:
`JobRunnerEndpointTests` — stands up an ASP.NET TestServer with `UseTraxJobRunner` and `UseTraxRunEndpoint` mapped, then exercises the happy + exception paths of both endpoint lambdas against an NSubstitute `ITraxRequestHandler`. Adds `Microsoft.AspNetCore.TestHost` and `Microsoft.AspNetCore.Mvc.Testing` to the test project.
`PollingServicesTests` — instantiates each of the four scheduler `BackgroundService`s (`ManifestManagerPollingService`, `JobDispatcherPollingService`, `MetadataCleanupPollingService`, `DeadLetterCleanupPollingService`) with a mock service-provider chain and verifies the immediate-cycle behavior, train-throw resilience, and the `JobDispatcherEnabled=false` skip path.
Local line coverage on Trax.Scheduler moves from 88.7% to 91.7%.
The remaining ~3% gap is in postgres-backed code that needs the existing `SchedulerE2EFixture` (postgres) to exercise: `EnqueueJobsJunction`, `DispatchJobsJunction` (uses `FOR UPDATE SKIP LOCKED` which InMemory doesn't support), and `DataContextExtensions`.
Test plan