test: exclude ArrayLogger test-fake assembly from coverage#55
Merged
Conversation
The ArrayLogger project is an in-memory ILoggerProvider used purely as a test fake — never shipped — so it has no business showing up in codecov totals (where it sat with ~80 lines at ~33% as an artificial drag of several percentage points on the aggregate).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Trax.Scheduler.Tests.ArrayLoggerproject is an in-memoryILoggerProviderused as a test fake (referenced by other test projects only, never shipped), but codecov was counting it in the totals — currently 27/80 lines (~33%), dragging the aggregate down by several percentage points.[assembly: ExcludeFromCodeCoverage]tells coverlet to skip the assembly cleanly.