test: deflake LocalWorkerServiceTests by polling completion conditions#57
Merged
test: deflake LocalWorkerServiceTests by polling completion conditions#57
Conversation
Replaces fixed Task.Delay(2000) and Task.Delay(3000) waits across 12 worker tests with poll-on-condition helpers (WaitUntilAsync, WaitForJobCount, WaitForJobAbsent). Each test now synchronises on the actual completion signal — queue drained, specific job deleted, or metadata advanced past Pending — and finishes as soon as the signal appears. The 15-second timeout is a safety ceiling, not a sleep. Local run drops from ~60s to ~5s for the affected tests, and CI scheduling variance up to 10x historical local timings can no longer flake them. The two intentional Task.Delays in this file are left untouched: the 500ms wait in Worker_DoesNotReclaim_RecentlyClaimedJob is verifying a negative outcome (job stays claimed within visibility timeout), and the 50ms waits in priority/FIFO setup ensure distinct created_at timestamps.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #56's audit. Replaces fixed
Task.Delay(2000)andTask.Delay(3000)waits across 12 worker tests inLocalWorkerServiceTestswithWaitUntilAsync/WaitForJobCount/WaitForJobAbsenthelpers that synchronise on the actual completion signal (queue drained, specific job deleted, or metadata advanced pastPending).The 15-second timeout is a safety ceiling, not a sleep. Each test finishes as soon as the underlying signal appears.
LocalWorkerServiceTestspass locally.The two intentional
Task.Delaycalls in this file are left untouched: the 500ms wait inWorker_DoesNotReclaim_RecentlyClaimedJobis verifying a negative outcome (job should NOT be reclaimed within the visibility timeout), and the 50ms waits in priority/FIFO setup ensure distinctcreated_attimestamps.Test plan
dotnet build— zero warningsdotnet csharpier check .— cleandotnet test --filter LocalWorkerServiceTests— 16/16 passing in 5s