Skip to content

feat: support custom oidc server #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions config-sample.ini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the naming -> see comment below as well please :-)

Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,16 @@ oauthClientId=
# Set the client secret for OAuth/OpenID authentication
# This is the secret of the client that will be used to verify the user's identity
oauthClientSecret=

# Set the base URL for the OpenID Connect issuer
# Default value is "https://accounts.google.com"
issuerBaseUrl=

# Set the name of the OpenID Connect issuer
# This name will be displayed on the login (/login) interface.
# Default value is "Google"
issuerName=

# Set the URL of the icon for the OpenID Connect issuer
# This icon will be displayed on the login (/login) interface.
issuerIcon=
2 changes: 2 additions & 0 deletions src/routes/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ function loginPage(req: Request, res: Response) {
wrongTotp: false,
totpEnabled: totp.isTotpEnabled(),
ssoEnabled: openID.isOpenIDEnabled(),
ssoName: openID.getSsoName(),
ssoIcon: openID.getSsoIcon(),
assetPath: assetPath,
appPath: appPath,
});
Expand Down
14 changes: 13 additions & 1 deletion src/services/config.ts
Copy link
Member

@pano9000 pano9000 May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the added config names should be prefixed with a more descriptive prefix, because reading e.g. TRILIUM_ISSUER_NAME is not really telling me what that is.
Something like TRILIUM_OPENID_ISSUER_NAME or TRILIUM_OIDC_ISSUER_NAME is a lot more clear.
(correct me if my terminology is wrong here though, not a huge expert on OAUTH vs OpenID and how all that is intertwined).

it would also be more "inline" with the other config naming

what do you think?

Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export interface TriliumConfig {
oauthBaseUrl: string;
oauthClientId: string;
oauthClientSecret: string;
issuerBaseUrl: string;
issuerName: string;
issuerIcon: string;
};
}

Expand Down Expand Up @@ -119,7 +122,16 @@ const config: TriliumConfig = {
process.env.TRILIUM_OAUTH_CLIENT_ID || iniConfig?.MultiFactorAuthentication?.oauthClientId || "",

oauthClientSecret:
process.env.TRILIUM_OAUTH_CLIENT_SECRET || iniConfig?.MultiFactorAuthentication?.oauthClientSecret || ""
process.env.TRILIUM_OAUTH_CLIENT_SECRET || iniConfig?.MultiFactorAuthentication?.oauthClientSecret || "",

issuerBaseUrl:
process.env.TRILIUM_ISSUER_BASE_URL || iniConfig?.MultiFactorAuthentication?.issuerBaseUrl || "https://accounts.google.com",

issuerName:
process.env.TRILIUM_ISSUER_NAME || iniConfig?.MultiFactorAuthentication?.issuerName || "Google",

issuerIcon:
process.env.TRILIUM_ISSUER_ICON || iniConfig?.MultiFactorAuthentication?.issuerIcon || ""
}
};

Expand Down
17 changes: 14 additions & 3 deletions src/services/open_id.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ function isTokenValid(req: Request, res: Response, next: NextFunction) {
}
}

function getSsoName() {
return config.MultiFactorAuthentication.issuerName
}

function getSsoIcon() {
return config.MultiFactorAuthentication.issuerIcon
}

function generateOAuthConfig() {
const authRoutes = {
callback: "/callback",
Expand All @@ -105,7 +113,7 @@ function generateOAuthConfig() {
auth0Logout: false,
baseURL: config.MultiFactorAuthentication.oauthBaseUrl,
clientID: config.MultiFactorAuthentication.oauthClientId,
issuerBaseURL: "https://accounts.google.com",
issuerBaseURL: config.MultiFactorAuthentication.issuerBaseUrl,
secret: config.MultiFactorAuthentication.oauthClientSecret,
clientSecret: config.MultiFactorAuthentication.oauthClientSecret,
authorizationParams: {
Expand All @@ -128,8 +136,9 @@ function generateOAuthConfig() {

openIDEncryption.saveUser(
req.oidc.user.sub.toString(),
req.oidc.user.name.toString(),
req.oidc.user.email.toString()
// The claims of the ID token do not include name and email by default.
req.oidc.user.name?.toString() || "none",
req.oidc.user.email?.toString() || "none"
);

req.session.loggedIn = true;
Expand All @@ -148,6 +157,8 @@ export default {
generateOAuthConfig,
getOAuthStatus,
isOpenIDEnabled,
getSsoName,
getSsoIcon,
clearSavedUser,
isTokenValid,
isUserSaved,
Expand Down
4 changes: 2 additions & 2 deletions src/views/login.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

<% if (ssoEnabled) { %>
<a href="/authenticate" class="google-login-btn">
<img src="<%= assetPath %>/images/google-logo.svg" alt="Google logo">
<%= t("login.sign_in_with_google") %>
<img src="<%= ssoIcon.length === 0 ? assetPath + '/images/google-logo.svg' : ssoIcon %>" alt="<%= ssoName %>">
<%= t("login.sign_in_with_sso", { ssoName }) %>
</a>
<% } else { %>
<form action="login" method="POST">
Expand Down
2 changes: 1 addition & 1 deletion translations/cn/server.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"password": "密码",
"remember-me": "记住我",
"button": "登录",
"sign_in_with_google": "使用 Google 登录"
"sign_in_with_sso": "使用 {{ ssoName }} 登录"
},
"set_password": {
"title": "设置密码",
Expand Down
2 changes: 1 addition & 1 deletion translations/en/server.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"password": "Password",
"remember-me": "Remember me",
"button": "Login",
"sign_in_with_google": "Sign in with Google"
"sign_in_with_sso": "Sign in with {{ ssoName }}"
},
"set_password": {
"title": "Set Password",
Expand Down