Store initial "automatic read-only" decision, so that actively edited Note doesn't transition to read-only #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…only threshold is triggered feat(client): stop the cursor from going to the top of the note when note transitions to read-only but we're still editing feat(client): stop the cursor from going to the top of the note when note transitions to read-only but we're still editing, take 2
feat(client): revert note_details.ts
perfectra1n
force-pushed
the
feat/note-edit-readonly-fix2
branch
from
68ae7c9 to
caccbf4
Compare
perfectra1n
changed the title
readOnlyTemporarilyDisabled when "automatic read-only" threshold is crossed for text Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Note triggers "automatic read-only" threshold but is still being edited, trigger
readOnlyTemporarilyDisabledevent so that the user's edits still go through while they're still editing the Note.Upon refreshing the Note frontend, it will appropriately go into read-only mode.
Closes #1877