-
-
Notifications
You must be signed in to change notification settings - Fork 157
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also update the Docker installation documentation to provide some info about these rootless modes (what is the benefit, how to use them, etc.).
Sounds good, I can do that. Since I already had another PR open for editing docs, I didn't want to merge conflict myself 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, shouldn't we actually do something with the rootless Docker images?
i.e. publish them to the DockerHub and integrate them into the CI for testing.
I was going to have separate PRs for those, I just wanted to add the Dockerfiles first 😂 |
…on if uid/gid are wrong
If you do want me to add the Actions in this PR too, let me know :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the necessary changes after the changes I've introduced with the switch to ESBuild.
The Docker files now build, but I can't seem to run them (notice that I'm running them via a NX command):
> nx run server:docker-start:rootless-debian
> docker run -p 8081:8080 triliumnext-rootless-debian
/bin/sh: 1: /home/trilium/app/rootless-entrypoint.sh: not found
No description provided.