Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

feat(ci): add rootless dockerfiles #1923

Merged
merged 19 commits into from
May 27, 2025
Merged

Conversation

perfectra1n
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 13, 2025

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-Server-1923-merge-linux-x64.tar.xz 66.72MB +66.72MB (+100.00%)
TOTAL +66.72MB

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the Docker installation documentation to provide some info about these rootless modes (what is the benefit, how to use them, etc.).

@eliandoran eliandoran marked this pull request as draft May 14, 2025 05:58
@perfectra1n
Copy link
Member Author

Sounds good, I can do that. Since I already had another PR open for editing docs, I didn't want to merge conflict myself 😂

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, shouldn't we actually do something with the rootless Docker images?

i.e. publish them to the DockerHub and integrate them into the CI for testing.

@perfectra1n
Copy link
Member Author

I was going to have separate PRs for those, I just wanted to add the Dockerfiles first 😂

@perfectra1n perfectra1n marked this pull request as ready for review May 22, 2025 22:54
@perfectra1n perfectra1n requested a review from eliandoran May 23, 2025 17:29
@perfectra1n
Copy link
Member Author

If you do want me to add the Actions in this PR too, let me know :)

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the necessary changes after the changes I've introduced with the switch to ESBuild.

The Docker files now build, but I can't seem to run them (notice that I'm running them via a NX command):

> nx run server:docker-start:rootless-debian

> docker run -p 8081:8080 triliumnext-rootless-debian

/bin/sh: 1: /home/trilium/app/rootless-entrypoint.sh: not found

@eliandoran eliandoran marked this pull request as draft May 25, 2025 19:01
@eliandoran eliandoran added this to the v0.94.0 milestone May 25, 2025
@perfectra1n
Copy link
Member Author

I...have no idea, it works for me?
image

Maybe you have an old container named that? I don't see you doing:

nx run server:docker-build:rootless-debian

In the step prior to running it. That error is from many commits back - so maybe you built it prior and you're referencing that name still (and not building it again)?

You could also run:

docker system prune -af

To get rid of all your dangling images...

@eliandoran eliandoran marked this pull request as ready for review May 27, 2025 17:06
@eliandoran eliandoran merged commit c82c01f into develop May 27, 2025
3 checks passed
@eliandoran eliandoran deleted the feat/add-rootless-dockerfiles branch May 27, 2025 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants