Skip to content

Conversation

@warcampsurvivor
Copy link

No description provided.

@warcampsurvivor
Copy link
Author

this should be it all the original comments are there

@warcampsurvivor
Copy link
Author

combo added to the main repo

Copy link
Member

@Win32Stuxnet Win32Stuxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too much of the original codebase ripped for no good reasoning / requesting re-write with comments for better readability so I know why half of this code was ripped out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to this repo

*/

import React, { useMemo } from "react";
import React, { useMemo, useState, createContext, useContext, useEffect, useRef, useCallback, memo } from "react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you kindly provide comments in your commits, as to the justifications of your changes?

I am questioning why there's bootstrap seemingly being added in, but still uses a mashed together react codebase ???

Can I ask, are you using AI?

I have no issues with AI, but this seems to be primarily written by AI with no review by the developer before commit

@Win32Stuxnet
Copy link
Member

Overviewing your code, it is blatantly AI driven, and adds complexity to an already exhausted code-base.

I'll pass it on to @LunaUrsa to make a final decision, I will be writing a contributors guide today.

I had also forked your personal repo of this, and I am actually just lost at what you are trying to achieve with this PR. A no merge from me

@Win32Stuxnet
Copy link
Member

Flagging commit PR inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants