-
Notifications
You must be signed in to change notification settings - Fork 7
Update Factsheets.tsx #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
this should be it all the original comments are there |
|
combo added to the main repo |
Win32Stuxnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way too much of the original codebase ripped for no good reasoning / requesting re-write with comments for better readability so I know why half of this code was ripped out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to this repo
| */ | ||
|
|
||
| import React, { useMemo } from "react"; | ||
| import React, { useMemo, useState, createContext, useContext, useEffect, useRef, useCallback, memo } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you kindly provide comments in your commits, as to the justifications of your changes?
I am questioning why there's bootstrap seemingly being added in, but still uses a mashed together react codebase ???
Can I ask, are you using AI?
I have no issues with AI, but this seems to be primarily written by AI with no review by the developer before commit
|
Overviewing your code, it is blatantly AI driven, and adds complexity to an already exhausted code-base. I'll pass it on to @LunaUrsa to make a final decision, I will be writing a contributors guide today. I had also forked your personal repo of this, and I am actually just lost at what you are trying to achieve with this PR. A no merge from me |
|
Flagging commit PR inactive |
No description provided.