fix(security): enforce escrow mediation in repayment flow#116
Open
Joseph-1-Duro wants to merge 3 commits into
Open
fix(security): enforce escrow mediation in repayment flow#116Joseph-1-Duro wants to merge 3 commits into
Joseph-1-Duro wants to merge 3 commits into
Conversation
|
@Joseph-1-Duro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
fix Ci error @Joseph-1-Duro |
Joseph-1-Duro
force-pushed
the
fix/route-repayments-through-escrow
branch
from
03e53e8 to
8aa9600
Compare
Contributor
|
Please Resolve Merge conflict @Joseph-1-Duro |
Resolved conflicts: - escrow/src/lib.rs: use > check (prevent overpayment) - escrow/src/test.rs: rename test to test_release_to_pool_fails_on_overpayment, use amount + 1 - invoice/src/lib.rs: combine amount param with escrow routing - Escrow/pool snapshots: keep HEAD (escrow-routed) versions
Joseph-1-Duro
force-pushed
the
fix/route-repayments-through-escrow
branch
from
0e49c54 to
acedc4a
Compare
Contributor
|
Please resolcve merge conflict @Joseph-1-Duro |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #59