chore(ci,repo): pin Rust 1.85.0 and wasm32v1-none target - #336
Merged
Conversation
…d toolchain file Aligns CI with the README's mandated toolchain and Stellar's expected wasm target. Adds a repo-root rust-toolchain.toml so contributors get the same version locally without any manual rustup setup, updates the CI workflow to install and build against 1.85.0 / wasm32v1-none, and points the README quick-start at the new toolchain file. Closes #283 Closes #284 Closes #285
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns CI with the README's mandated toolchain and Stellar's expected wasm target — a combined landing of the three interdependent tickets that could not be shipped separately without breaking CI.
rust-toolchain.tomlat repo root pinningchannel = 1.85.0+targets = [wasm32v1-none]+components = [clippy, rustfmt]so contributors get the same toolchain locally with zero rustup setup..github/workflows/ci.yml:dtolnay/rust-toolchain@stable→@masterwith explicittoolchain: 1.85.0(matches README:127)targets: wasm32-unknown-unknown→wasm32v1-none(matches Stellar CLI's expected target, README:134)wasm32v1-noneso CI artifacts are bit-for-bit comparable tostellar contract buildoutputrustup toolchain installsteps stay as an install fallback.Why bundled
#285 alone (adding
rust-toolchain.tomlwithwasm32v1-none) would break CI because the workflow still installswasm32-unknown-unknownand builds against it. #283 and #284 alone would leave the client-side gap (contributors still get whateverrustup defaultis set to). All three must land together — hence the combined PR after #333 was closed as premature.Test plan
build-and-testjob goes green on this PRcargo build --workspace --release --target wasm32v1-nonesucceeds on the runnercargo test --workspacestill passes (host target unchanged)cargo fmt --all --checkandcargo clippy --all-targets --all-features -- -D warningsstill passCloses #283
Closes #284
Closes #285