test(e2e): add notifications flow coverage (#79)#99
Open
Ayomisco wants to merge 1 commit intoTrustUp-app:mainfrom
Open
test(e2e): add notifications flow coverage (#79)#99Ayomisco wants to merge 1 commit intoTrustUp-app:mainfrom
Ayomisco wants to merge 1 commit intoTrustUp-app:mainfrom
Conversation
Josue19-08
requested changes
Apr 28, 2026
Contributor
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @Ayomisco, thank you for your contribution to the project! 🙌
Two things to sort out:
-
Mock-only vs. real database — Issue #79 explicitly requires
"Use test database for state validation" and "Verify database state changes after marking as read."
The current suite mocksSupabaseServiceentirely, so no real DB state is ever verified (e.g., thatis_readactually flips totrueor thatread_atis persisted). Please update the suite to connect to a real test database. -
Duplicate PR on the same issue — PR #100 also targets issue #79.
Please coordinate with the maintainer so it's clear which one will move forward before investing more work.
Feel free to reach out with any questions. Thanks again! 🚀
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Closes #79.
Contributes to #68 (E2E Integration Test Coverage Tracker).
This PR adds end-to-end integration test coverage for the Notifications flow, following the project testing structure and module-based E2E organization.
What was added
Covered scenarios
GET /notifications
PATCH /notifications/read-all
PATCH /notifications/:id/read
Validation
Executed:
Result:
Notes
Closes #79.