Skip to content

Added paywallImprovements feature flag - #29611

Merged
kevinansfield merged 1 commit into
mainfrom
kevin-ber-3822-add-paywallimprovements-feature-flag
Jul 27, 2026
Merged

kevinansfield merged 1 commit into
mainfrom
kevin-ber-3822-add-paywallimprovements-feature-flag

Conversation

@kevinansfield

Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3822/add-paywallimprovements-feature-flag

The paywall usability, discoverability & email customization project ships every user-visible slice behind a flag, so the flag needs to exist before the first feature lands — otherwise each subsequent PR has to bundle the flag plumbing with its own behaviour change.

Registers paywallImprovements as a private (developer experiments) feature flag: backend registration in labs.js plus the Labs settings toggle. Private rather than public beta because nothing here is ready to be exposed to users yet.

There is no user-facing behaviour beyond the toggle appearing under developer experiments.

ref https://linear.app/ghost/issue/BER-3822/add-paywallimprovements-feature-flag

- the paywall usability, discoverability and email customization project
  ships every user-visible slice behind a flag, so the flag needs to exist
  before the first feature lands
- private rather than public beta because nothing is ready to be exposed to
  users yet - it only shows up under developer experiments
@nx-cloud

nx-cloud Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 60238d7

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 3m 17s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 17s View ↗
nx run @tryghost/admin:test:acceptance ✅ Succeeded 6m 20s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 6s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 48s View ↗
nx run-many -t test:unit -p @tryghost/admin-x-s... ✅ Succeeded 2m 52s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 18s View ↗
nx run-many -t lint -p @tryghost/admin-x-settin... ✅ Succeeded 1m 11s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-27 12:54:32 UTC

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dcfe1b01-2e55-48c0-8eff-9c278cd9c716

📥 Commits

Reviewing files that changed from the base of the PR and between 1a065a5 and 60238d7.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
  • ghost/core/core/shared/labs.js

Walkthrough

Adds the paywallImprovements private labs flag to the shared labs registry and the admin settings private-features list. The flag is consequently included in derived writable and available labs keys, and the “Paywall improvements” entry can be rendered through the existing AlphaFeatures flow when filtering permits it.

Suggested reviewers: 9larsons, erisds

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding the paywallImprovements feature flag.
Description check ✅ Passed The description accurately describes the flag registration and Labs toggle changes in the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kevin-ber-3822-add-paywallimprovements-feature-flag

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.02%. Comparing base (1a065a5) to head (60238d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29611      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.02%     
==========================================
  Files        1610     1610              
  Lines      141706   141707       +1     
  Branches    17389    17384       -5     
==========================================
- Hits       106334   106309      -25     
- Misses      34310    34336      +26     
  Partials     1062     1062              
Flag Coverage Δ
e2e-tests 77.12% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant