Skip to content

✨ Added new analytics fields to automations list - #30155

Merged
EvanHahn merged 1 commit into
fix-admin-build-cache-permissionsfrom
automation-run-analytics-flag-shouldnt-affect-table
Aug 24, 2026
Merged

EvanHahn merged 1 commit into
fix-admin-build-cache-permissionsfrom
automation-run-analytics-flag-shouldnt-affect-table

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

ref df5535b

Manual test

Disabled the flag:

Screenshot 1

And I can see the new columns:

Screenshot 2

@EvanHahn
EvanHahn marked this pull request as draft August 20, 2026 15:13
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: fbb7b432-7b2d-4ae1-9f50-533cb4c1efe6

📥 Commits

Reviewing files that changed from the base of the PR and between e24e6c0 and 4aa9b41.

📒 Files selected for processing (5)
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/automations.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
💤 Files with no reviewable changes (1)
  • apps/admin/src/automations/automations.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: Setup
  • GitHub Check: Detect Tinybird changes
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (Custom checks)

**/*.{ts,tsx}: Type-safe boundaries: Fail only if the PR:

  • consumes boundary data (HTTP input, external API/SDK responses, env/config,
    DB/filesystem reads, queue/webhook/event payloads) without validating it
    first — Zod by default, another format only where an external contract
    requires it; or
  • introduces any, unchecked as, @ts-nocheck, or @ts-ignore to bypass
    typing boundary data; or
  • hand-writes a type duplicating a shape a Zod schema describes (use z.infer).
    Never fail for: internal function/module calls (no runtime validation needed),
    pre-existing JS files touched incidentally, tests, scripts, or config files.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
**/*

📄 CodeRabbit inference engine (AGENTS.md)

Always use pnpm, never npm or Yarn.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx

⚙️ CodeRabbit configuration file

**/*: Prioritise concrete correctness, security, data-integrity, compatibility,
and regression risks. Explain the failure mode and point to the affected
code. Do not report formatting, naming, import ordering, type errors, or
other findings already owned by configured static tools or failing GitHub
checks. Do not request speculative abstractions, broad refactors, generic
documentation, or tests unrelated to changed behaviour. For a move,
rename, TypeScript conversion, or explicitly behaviour-preserving refactor,
do not report pre-existing problems unless the diff introduces or worsens
them, makes them newly reachable, or prevents the stated transformation
from being correct. Treat nearby AGENTS.md files and mapped codebase
documentation as authoritative; do not enforce proposals, plans, or
historical guidance as current policy.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
apps/admin/**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

apps/admin/**/*.{js,jsx,ts,tsx}: Build new features in React,
use admin-x-framework for APIs, and use Shade for UI.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
**/*.{ts,tsx,mts,cts}

⚙️ CodeRabbit configuration file

**/*.{ts,tsx,mts,cts}: Review lens: "where does this data become trusted?"

  • Boundary data (HTTP input, external API/SDK responses, env/config,
    DB/filesystem reads, queue/webhook/event payloads) is unknown until
    validated — Zod by default.
  • Infer boundary types via z.infer/z.input; flag handwritten duplicates.
  • Flag any, unchecked as on boundary data, @ts-nocheck, and unexplained
    @ts-ignore/@ts-expect-error.
  • Validated data stays trusted: don't request Zod on internal calls, and flag
    redundant re-validation.
  • ghost/core golden path: schema.ts owns Zod schemas + inferred types, with
    codec/serializer modules at the edges (see core/server/services/gift-links).
  • Looser typing in tests is fine unless it hides a real defect.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
apps/{admin,activitypub,admin-x-framework,shade}/**/*.{ts,tsx}

⚙️ CodeRabbit configuration file

apps/{admin,activitypub,admin-x-framework,shade}/**/*.{ts,tsx}: Review Admin UI for existing Shade reuse, correct component layer, semantic
tokens, accessible interaction states, and whole-sentence translations. New UI
that depends on backend settings, endpoints, or config must feature-detect old
backend support and cover the not-yet-deployed backend case. Do not apply these
rules to independent public UMD apps. Do not repeat ESLint/Tailwind findings.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
  • apps/admin/src/automations/components/automations-list.tsx
**/*{.,-}{test,spec}.{js,jsx,ts,tsx}

⚙️ CodeRabbit configuration file

**/*{.,-}{test,spec}.{js,jsx,ts,tsx}: Review whether tests prove changed behaviour, meaningful error/edge paths, and
externally observable contracts without coupling to implementation details.
Prefer the lowest useful test layer. Do not demand broad E2E coverage for
isolated logic or repeat test-run failures already visible in GitHub checks.

Files:

  • apps/admin/src/automations/components/automations-list.test.tsx
  • apps/admin/src/automations/automations.acceptance.test.tsx
🔇 Additional comments (4)
apps/admin/src/automations/automations.tsx (1)

9-11: LGTM!

Also applies to: 39-39

apps/admin/src/automations/components/automations-list.tsx (1)

53-60: LGTM!

Also applies to: 74-83, 95-124, 169-185

apps/admin/src/automations/components/automations-list.test.tsx (1)

44-44: LGTM!

Also applies to: 61-61, 81-85, 129-129

apps/admin/src/automations/automations.acceptance.test.tsx (1)

8-15: LGTM!

Also applies to: 41-41


Walkthrough

The automations page no longer reads or passes the automationRunAnalytics feature flag. AutomationsList always renders analytics columns, including loading-state columns and the “Last entry” column. Its props no longer include showRunAnalytics. Unit and acceptance tests now use the default analytics-enabled behavior and remove flag-specific coverage.

Suggested reviewers: 9larsons, troyciesco

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed The PR only ungates existing typed AutomationBrowseItem rendering; API hooks and boundary types are unchanged, and changed runtime lines add no any, unchecked as, or TS suppressions.
New Files Are Typescript ✅ Passed The PR diff against origin/main contains only five modified .tsx files and adds no .js, .jsx, .cjs, or .mjs source files.
Description check ✅ Passed The description documents manual testing that confirms analytics columns remain visible when the feature flag is disabled.
Title check ✅ Passed The title identifies the automation analytics fields, which are the main subject of the changes, although they were made always visible rather than newly added.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch automation-run-analytics-flag-shouldnt-affect-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 20, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit ed1f876

Command Status Duration Result
nx run @tryghost/admin:test:acceptance ✅ Succeeded 5m 30s View ↗
nx run-many -t test:unit -p @tryghost/admin ✅ Succeeded 2m 21s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 17s View ↗
nx run-many -t lint -p @tryghost/admin,ghost-mo... ✅ Succeeded 1m 6s View ↗
nx run @tryghost/admin:build ✅ Succeeded 18s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-24 21:35:52 UTC

coderabbitai[bot]

This comment was marked as low quality.

@EvanHahn
EvanHahn force-pushed the automation-run-analytics-flag-shouldnt-affect-table branch 2 times, most recently from 81a120c to 4aa9b41 Compare August 24, 2026 20:28
@EvanHahn
EvanHahn marked this pull request as ready for review August 24, 2026 20:28
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@EvanHahn EvanHahn changed the title Showed automation run analytics in table regardless of flag ✨ Added new analytics fields to automations list Aug 24, 2026
@EvanHahn
EvanHahn requested a review from troyciesco August 24, 2026 20:33
@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 32774072137 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@EvanHahn
EvanHahn enabled auto-merge (squash) August 24, 2026 20:46
@github-actions

This comment was marked as outdated.

3 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 32774072137 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 32774072137 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 32774072137 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@EvanHahn
EvanHahn disabled the stack merge August 24, 2026 21:27
@EvanHahn
EvanHahn force-pushed the automation-run-analytics-flag-shouldnt-affect-table branch from 4aa9b41 to ed1f876 Compare August 24, 2026 21:27
@EvanHahn
EvanHahn changed the base branch from main to fix-admin-build-cache-permissions August 24, 2026 21:27
@EvanHahn
EvanHahn merged commit 825943f into main Aug 24, 2026
50 checks passed
@EvanHahn
EvanHahn deleted the automation-run-analytics-flag-shouldnt-affect-table branch August 24, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants