Skip to content

🎨 Updated default node version to 24 - #30434

Closed
acburdine wants to merge 1 commit into
mainfrom
feat/node-24
Closed

acburdine wants to merge 1 commit into
mainfrom
feat/node-24

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • bump default node version to 24
  • widen engines block to include node 24
  • bump node types to 24

@acburdine
acburdine requested a review from 9larsons as a code owner September 1, 2026 17:43
@nx-cloud

nx-cloud Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit a359f66

Command Status Duration Result
nx run @tryghost/admin:test:acceptance ✅ Succeeded 7m 26s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-01 21:56:47 UTC

@codecov

codecov Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.14%. Comparing base (c57f7a6) to head (a359f66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30434      +/-   ##
==========================================
- Coverage   67.43%   67.14%   -0.30%     
==========================================
  Files        1656     1656              
  Lines       59939    59968      +29     
  Branches    10365    10372       +7     
==========================================
- Hits        40421    40266     -155     
- Misses      17240    17455     +215     
+ Partials     2278     2247      -31     
Flag Coverage Δ
admin-tests 57.51% <ø> (+0.04%) ⬆️
e2e-tests 69.84% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

E2E Tests Failed

To view the Playwright test report locally, run:

REPORT_DIR=$(mktemp -d) && gh run download 33545101115 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR"

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Team

Run ID: 31c41256-d8ca-49b1-9222-dabb1dc6fb0e

📥 Commits

Reviewing files that changed from the base of the PR and between d7e50d2 and a359f66.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/koenig-lexical)
  • GitHub Check: Acceptance tests (Node 24.20.0, mysql8)
  • GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
  • GitHub Check: Build Docker Images
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/admin)
  • GitHub Check: Unit tests (Node 22.23.1)
  • GitHub Check: Unit tests (Node 24.20.0)
  • GitHub Check: Legacy tests (Node 24.20.0, mysql8)
  • GitHub Check: Build Admin
  • GitHub Check: Legacy tests (Node 22.23.1, mysql8)
  • GitHub Check: Admin tests - Chrome
  • GitHub Check: Lint
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/ci.yml

[error] 1089-1089: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): enables caching by default

(cache-poisoning)

🔇 Additional comments (2)
.github/workflows/ci.yml (2)

18-18: LGTM!

Also applies to: 228-233, 1071-1087, 1115-1116, 1118-1119, 1128-1128


1089-1093: 🔒 Security & Privacy

Do not add the cache-setting change.

job_ghost-cli does not check out the repository before actions/setup-node. Without package.json, setup-node does not enable automatic package-manager caching, so the claimed cache-poisoning path is not reachable.


Walkthrough

The repository now supports Node.js 24.20.0 while retaining Node.js 22.23.1 support. Runtime pins, package engine ranges, Docker images, CI workflows, publishing workflows, documentation, and version checks were updated. CI tests Node.js 24.20.0 first and Node.js 22.23.1 second. Node type definitions and related package dependencies were updated.

Suggested reviewers: 9larsons

Merge Risk: ⚪ Minimal · up to a359f

The Node 24 compatibility updates introduce no concrete merge-blocking risk; the CI cache-setting change is unnecessary because the affected job does not check out the repository. The PR is merge-ready after normal checks.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the default Node.js version to 24.
Description check ✅ Passed The description directly covers the main changes: updating the default Node.js version, widening the engines range, and updating Node.js type definitions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS. The PR changes Node.js version pins, engine declarations, dependency metadata, lockfile resolutions, workflows, Dockerfiles, documentation, and a version-check message. The only source-like file…
New Files Are Typescript ✅ Passed The PR adds only .changeset/proud-clocks-reflect.md. It adds no new .js, .jsx, .cjs, or .mjs source file. The changed apps/ember-admin/lib/check-node-version.js file is pre-existing and is…
Full details: Type-Safe Boundaries

Explanation

PASS. The PR changes Node.js version pins, engine declarations, dependency metadata, lockfile resolutions, workflows, Dockerfiles, documentation, and a version-check message. The only source-like file touched is the pre-existing JavaScript version-check script, which the check explicitly exempts. No added TypeScript/runtime boundary-consumption code, Zod-shape duplication, any, unchecked as, @ts-nocheck, or @ts-ignore appears in the diff.

Full details: New Files Are Typescript

Explanation

The PR adds only .changeset/proud-clocks-reflect.md. It adds no new .js, .jsx, .cjs, or .mjs source file. The changed apps/ember-admin/lib/check-node-version.js file is pre-existing and is modified, not added.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/node-24

Comment @coderabbitai help to get the list of available commands.

no ref
- bump default node version to 24
- widen engines block to include node 24
- bump node types to 24
@acburdine

Copy link
Copy Markdown
Member Author

closing in favor of #30466

@acburdine acburdine closed this Sep 2, 2026
@acburdine
acburdine deleted the feat/node-24 branch September 2, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant