Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 7m 26s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-09-01 21:56:47 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30434 +/- ##
==========================================
- Coverage 67.43% 67.14% -0.30%
==========================================
Files 1656 1656
Lines 59939 59968 +29
Branches 10365 10372 +7
==========================================
- Hits 40421 40266 -155
- Misses 17240 17455 +215
+ Partials 2278 2247 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2aba111 to
ace4ae7
Compare
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 33545101115 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🧰 Additional context used🪛 zizmor (1.29.0).github/workflows/ci.yml[error] 1089-1089: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): enables caching by default (cache-poisoning) 🔇 Additional comments (2)
WalkthroughThe repository now supports Node.js 24.20.0 while retaining Node.js 22.23.1 support. Runtime pins, package engine ranges, Docker images, CI workflows, publishing workflows, documentation, and version checks were updated. CI tests Node.js 24.20.0 first and Node.js 22.23.1 second. Node type definitions and related package dependencies were updated. Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Node 24 compatibility updates introduce no concrete merge-blocking risk; the CI cache-setting change is unnecessary because the affected job does not check out the repository. The PR is merge-ready after normal checks. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Type-Safe BoundariesExplanation PASS. The PR changes Node.js version pins, engine declarations, dependency metadata, lockfile resolutions, workflows, Dockerfiles, documentation, and a version-check message. The only source-like file touched is the pre-existing JavaScript version-check script, which the check explicitly exempts. No added TypeScript/runtime boundary-consumption code, Zod-shape duplication, Full details: New Files Are TypescriptExplanation The PR adds only ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
f20d392 to
d7e50d2
Compare
no ref - bump default node version to 24 - widen engines block to include node 24 - bump node types to 24
d7e50d2 to
a359f66
Compare
|
closing in favor of #30466 |

no ref