- 
                Notifications
    
You must be signed in to change notification settings  - Fork 295
 
A new extension for creating and managing multiple iframes. #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           Hello, please stop closing and recreating PRs Also please refrain from adding translations yourself in the PR. I see other edits but I can't check them out from my phone.  | 
    
          
 I'm sorry. These are my first pull request and I'm new to using Github.  | 
    
| 
           I’m still waiting for your reply.  | 
    
| 
           Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.  | 
    
          
 I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388".  | 
    
          
 have two separate blocks: one with the id and one without. as stated by the documentation, arguments must never be added to existing blocks.  | 
    
          
 That's a good idea!!  | 
    
| 
           !format  | 
    
A new extension for creating and managing multiple iframes.
From: #2310