Skip to content

Conversation

@izum00
Copy link

@izum00 izum00 commented Oct 27, 2025

A new extension for creating and managing multiple iframes.
From: #2310

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Oct 27, 2025
@CubesterYT
Copy link
Member

Hello, please stop closing and recreating PRs

Also please refrain from adding translations yourself in the PR. I see other edits but I can't check them out from my phone.

@izum00
Copy link
Author

izum00 commented Oct 27, 2025

Hello, please stop closing and recreating PRs

Also please refrain from adding translations yourself in the PR. I see other edits but I can't check them out from my phone.

I'm sorry. These are my first pull request and I'm new to using Github.
Also, what do you mean by "I see other edits but I can't check them out from my phone"?

@izum00
Copy link
Author

izum00 commented Oct 31, 2025

I’m still waiting for your reply.

@ScratchFakemon
Copy link
Contributor

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

@izum00
Copy link
Author

izum00 commented Nov 1, 2025

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388".
Therefore, adding only an argument to an existing extension is risky.
That pull request was submitted at #2310
and has since been closed.
This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

@ScratchFakemon
Copy link
Contributor

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388". Therefore, adding only an argument to an existing extension is risky. That pull request was submitted at #2310 and has since been closed. This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

have two separate blocks: one with the id and one without. as stated by the documentation, arguments must never be added to existing blocks.

@izum00
Copy link
Author

izum00 commented Nov 2, 2025

Imo it would be better to just add these features to the main iframe extension. I'm not a reviewer and these aren't official change requests, but I think you should at least look into how plausible it would be for the extension to support multiple iframes.

I also submitted a pull request to add an ID assignment feature for the iframe in the existing Iframe extension. My assumption was that projects already using the existing Iframe extension would leave the argument blank or use the extension’s default value, so I designed it so that if the ID argument was empty, the iframe would use a default ID of “iframe.” However, in practice, there is a high possibility that the argument fields of the blocks may not display properly - such as in "https://studio.penguinmod.com/#1781399388". Therefore, adding only an argument to an existing extension is risky. That pull request was submitted at #2310 and has since been closed. This demonstrates that existing extensions cannot be easily replaced, and by releasing it as a new extension, I aimed to avoid such bugs.

have two separate blocks: one with the id and one without. as stated by the documentation, arguments must never be added to existing blocks.

That's a good idea!!
I will fix it.

@izum00 izum00 reopened this Nov 2, 2025
@izum00
Copy link
Author

izum00 commented Nov 2, 2025

!format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants