-
Notifications
You must be signed in to change notification settings - Fork 37
Make VarNamedVector the default metadata type #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mhauru
wants to merge
14
commits into
breaking
Choose a base branch
from
mhauru/varnamedvector-as-default
base: breaking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+79
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo be UntypedVectorVarInfo
Benchmark Report for Commit a76e366Computer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #1105 +/- ##
=============================================
- Coverage 81.23% 32.89% -48.35%
=============================================
Files 40 40
Lines 3805 3791 -14
=============================================
- Hits 3091 1247 -1844
- Misses 714 2544 +1830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin.
Metadatastuff is renamed asUntypedLegacyVarInfoand(un)typed_legacy_varinfo.UntypedVarInfoand(un)typed_varinfobecome synonyms for theUntypedVectorVarInfoand(un)typed_vector_varinfo.The diff is currently a mess because this builds on #1102. Opening this early to run all of CI on GHAs.
This doesn't need to be merged into
breaking, since changes are internal. Considering how these code paths are invoked by everything we do in Turing.jl though, I would be surprised if something didn't break, and thus I think a breaking version bump is the right choice.Whether these changes should even be released before VarNamedTuple changes are in can be discussed.