Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set up transition to TypeScript #98

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
.idea
.meteor
.npm
node_modules
packages/*
smart.lock
versions.json

docs/client/data

Expand Down
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ before_install:
# Later stuff for Meteor 1.4: see https://github.com/arunoda/travis-ci-meteor-packages/pull/45
# Make sure this matches what is in package.json.
env:
- CXX=g++-4.8 METEOR_RELEASE=1.4.4.6
# barbatus:typescript requires ecmascript and modules from 1.6.x, so we just
# use that to run the test
- CXX=g++-4.8 METEOR_RELEASE=1.6.1.4
addons:
apt:
sources:
Expand Down
8 changes: 8 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"editor.formatOnSave": true,
"files.exclude": {
"**/.npm": true, // this excludes all folders from the explore tree
"**/node_modules": true,
"packages": true // this excludes the folder only from the root
}
}
9 changes: 6 additions & 3 deletions Contributing.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
## Code

This repo is written in ES6 with a `.prettierrc` to auto-format code.
This repo is written in ES6/TypeScript with a `.prettierrc` to auto-format code.

Initial parts of this codebase were written in Coffeescript. However, ES6
implements many useful functions from Coffeescript while allowing more people to
read the code and contribute. We [decaffeinated] the repo and in the future may
convert fully to TypeScript.
read the code and contribute. We [decaffeinated] the repo then converted to TypeScript.

[decaffeinated]: https://github.com/TurkServer/turkserver-meteor/pull/99

## Development

`yarn install` will grab `@types/meteor` for developing the package.

TODO: set up format or lint hooks with something like AirBnb's [Javascript style
guide](https://github.com/airbnb/javascript).

Expand Down
Loading