-
-
Notifications
You must be signed in to change notification settings - Fork 491
fix(client): Use libcap to fix icmp not working in containers as non-root #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this is causing an issue: #1057 I may have to revert this if we can't find a fix |
I think there are three options here:
|
The chaotic inside of me just makes me feel like having those using podman deal with it, mostly because podman users are a minority. |
Based on what I'm seeing on containerd/containerd#10434, it seems like CAP_NET_RAW being enabled by default may be changed in the future. I wonder if the current default behavior is why Gatus worked just fine for me on Kubernetes even before this change? |
Summary
Fixes #697
This PR modifies the Gatus binary in the container to have the CAP_NET_RAW capability. Gatus can now perform ICMP monitoring without running as a privileged or root container.
Checklist
README.md
, if applicable.