Fix #124: Add max-length validation to bypass bcrypt's silent 72-byte truncation#278
Open
rexx010 wants to merge 1 commit into
Open
Fix #124: Add max-length validation to bypass bcrypt's silent 72-byte truncation#278rexx010 wants to merge 1 commit into
rexx010 wants to merge 1 commit into
Conversation
Add a short explanatory comment above the max = 72 length validator on each password-carrying field so the constraint's origin (bcrypt's hard input limit) is clear at a glance. - RegisterUserRequest.password - LoginRequest.password - ResetPasswordWithOTPRequest.new_password - UpdatePasswordRequest.new_password Ref Txio-labs#124
|
@rexx010 is attempting to deploy a commit to the oladimejivictor611-5012's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
Heads up — this issue was reopened by the Grantfox bot after it
reassigned #124 to me, since its workflow expects an associated
PR before a reassigned issue can be marked resolved.
The underlying fix (password DTO
max = 72validation) was alreadymerged in a prior PR — see lines 9, 17, 41, 54 of
backend/api/src/dtos/request.rs, plus the regression tests inpassword_length_tests(lines 73–139).Nothing was changed, i just added comments on the fixes i made in the
last PR so that i'll be able to open a PR and close the issue