-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle languageclient errors cases more robustly #859
Conversation
3acab64
to
56f4992
Compare
- Added a unit test
@CGNonofr last commit is for the problem @cdietrich discovered with the react component introduced by 6.3.0 version. We now have 78 unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not easy to review! 😢 LGTM though
@CGNonofr sorry, once I started fixing the tests the domino effect started. |
As always, same for me 😆 |
@CGNonofr These changes made the |
I moved some tests around (wrong places) as well.
Fixing the wrapper handling in case of error introduced required changes to the react component and to several tests.
After thinking about #855