Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to monaco-vscode-api 14.0.4 and incremented versions to x.4.0. #863

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Feb 15, 2025

  • Fixed button handling in state machine examples
  • Updated dependencies
  • Brings back pre-bundled workers, now with proper unit test verifying their usage
    • Separate classic monaco-editor tests from extended mode test (applies to monaco-editor-wrapper and @type/monaco-editor-react)

@CGNonofr preparation for the next release.

@kaisalmen kaisalmen requested a review from CGNonofr as a code owner February 15, 2025 20:50
@kaisalmen kaisalmen marked this pull request as draft February 17, 2025 09:00
@kaisalmen
Copy link
Collaborator Author

@CGNonofr I need to update the README and it seem to make sense to bring back the pre-bundled workers.

@kaisalmen
Copy link
Collaborator Author

@CGNonofr oh, that was more work than expected, but now there are a couple of unit tests verifying the correct workers are loaded.
README update is missing

- Fixed button handling in state machine examples
- Updated dependencies
… usage.

- Add an additional test configuration only for classic monaco-editor test
@kaisalmen kaisalmen marked this pull request as ready for review February 17, 2025 15:57
@kaisalmen
Copy link
Collaborator Author

@CGNonofr README update is done. This is ready for review. My apologies for another long PR. Another improvements to the unit tests. We have reached 83 unit tests. 🎉

@kaisalmen kaisalmen merged commit 3b1b25c into main Feb 18, 2025
1 check passed
@kaisalmen kaisalmen deleted the mva-next branch February 18, 2025 13:03
@kaisalmen
Copy link
Collaborator Author

@CGNonofr I merged this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant