Skip to content

Bypass updater local and CDN HTTP cache on check for updates #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MineraleYT wants to merge 8 commits into from
Closed

Bypass updater local and CDN HTTP cache on check for updates #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
935aeb8
chore: update plugin detailsURL to point to TypeWhisper documentation
MineraleYT Jun 18, 2026
04e4455
Merge branch 'TypeWhisper:main' into main
MineraleYT Jun 19, 2026
6960e3d
Merge remote-tracking branch 'upstream/main'
MineraleYT Jun 19, 2026
702e9d2
Merge branch 'TypeWhisper:main' into main
MineraleYT Jun 21, 2026
3a7c789
Merge branch 'TypeWhisper:main' into main
MineraleYT Jun 22, 2026
f980d46
Merge branch 'TypeWhisper:main' into main
MineraleYT Jul 11, 2026
d69c6a2
Fix: Bypass updater local and CDN HTTP cache on check for updates
MineraleYT Jul 14, 2026
31a760e
chore: update Sparkle to 2.9.4 and migrate to feedParameters for cach…
MineraleYT Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TypeWhisper.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions TypeWhisper/App/TypeWhisperApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,4 +692,13 @@ final class AppDelegate: NSObject, NSApplicationDelegate, SPUUpdaterDelegate {
nonisolated func allowedChannels(for updater: SPUUpdater) -> Set<String> {
AppConstants.effectiveUpdateChannel.sparkleChannels
}

nonisolated func feedParameters(for updater: SPUUpdater, sendingSystemProfile: Bool) -> [[String : String]] {

@SeoFood SeoFood Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now a real Sparkle delegate callback, but it still does not bypass the CDN in front of the actual feed. I sent three requests to https://typewhisper.github.io/typewhisper-mac/appcast.xml with different UUID values for nocache; GitHub Pages returned the same cached object for all three (x-cache: HIT with an identical x-github-request-id). The query string is therefore not part of the effective cache key for this feed, so this changes every updater URL without making the appcast fresh.

Please remove this cache-buster and solve freshness at the hosting/release layer, or move the feed to an endpoint whose cache behavior can be controlled. The fix needs an end-to-end check that can distinguish stale and newly published appcast content.

return [[
"key": "nocache",
"value": String(Int(Date().timeIntervalSince1970)),
"displayKey": "",
"displayValue": ""
]]
}
}
Loading