Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sar quick #106

Open
wants to merge 10 commits into
base: sar_quick
Choose a base branch
from
Open

Sar quick #106

wants to merge 10 commits into from

Conversation

McWhity
Copy link

@McWhity McWhity commented Dec 2, 2019

LMU tested installation and outputs of branch.

  • Update of setup.py for installation (including import issues)
  • change hard coded file names of Sentinel-1 input data files

@pep8speaks
Copy link

Hello @McWhity! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:58: E502 the backslash is redundant between brackets
Line 28:21: E131 continuation line unaligned for hanging indent

Line 31:17: E128 continuation line under-indented for visual indent
Line 31:37: E251 unexpected spaces around keyword / parameter equals
Line 31:39: E251 unexpected spaces around keyword / parameter equals

Line 18:1: E302 expected 2 blank lines, found 1
Line 21:80: E501 line too long (118 > 79 characters)
Line 23:80: E501 line too long (269 > 79 characters)
Line 27:42: E201 whitespace after '('
Line 27:48: E202 whitespace before ')'
Line 33:80: E501 line too long (112 > 79 characters)
Line 35:13: E221 multiple spaces before operator
Line 37:14: E221 multiple spaces before operator
Line 38:19: E221 multiple spaces before operator
Line 39:9: E221 multiple spaces before operator
Line 47:58: E228 missing whitespace around modulo operator
Line 53:58: E228 missing whitespace around modulo operator
Line 59:57: E228 missing whitespace around modulo operator
Line 64:80: E501 line too long (99 > 79 characters)
Line 66:1: E302 expected 2 blank lines, found 1
Line 67:80: E501 line too long (96 > 79 characters)
Line 69:80: E501 line too long (87 > 79 characters)
Line 70:7: E221 multiple spaces before operator
Line 70:80: E501 line too long (86 > 79 characters)
Line 71:7: E221 multiple spaces before operator
Line 71:80: E501 line too long (86 > 79 characters)
Line 73:35: E231 missing whitespace after ','
Line 73:37: E231 missing whitespace after ','
Line 73:80: E501 line too long (100 > 79 characters)
Line 73:85: E271 multiple spaces after keyword
Line 74:80: E501 line too long (129 > 79 characters)
Line 76:1: E302 expected 2 blank lines, found 1
Line 84:8: E221 multiple spaces before operator
Line 85:8: E221 multiple spaces before operator
Line 86:11: E221 multiple spaces before operator
Line 86:80: E501 line too long (83 > 79 characters)
Line 89:1: E302 expected 2 blank lines, found 1
Line 94:80: E501 line too long (150 > 79 characters)
Line 97:5: E303 too many blank lines (2)
Line 97:25: E201 whitespace after '['
Line 98:25: E201 whitespace after '['
Line 102:80: E501 line too long (80 > 79 characters)
Line 104:80: E501 line too long (80 > 79 characters)
Line 106:80: E501 line too long (83 > 79 characters)
Line 110:29: E225 missing whitespace around operator
Line 111:11: E221 multiple spaces before operator
Line 112:80: E501 line too long (83 > 79 characters)
Line 113:80: E501 line too long (80 > 79 characters)
Line 114:80: E501 line too long (80 > 79 characters)
Line 115:80: E501 line too long (113 > 79 characters)
Line 120:80: E501 line too long (101 > 79 characters)
Line 132:13: E221 multiple spaces before operator
Line 132:80: E501 line too long (92 > 79 characters)
Line 133:11: E221 multiple spaces before operator
Line 133:80: E501 line too long (92 > 79 characters)
Line 134:13: E221 multiple spaces before operator
Line 134:80: E501 line too long (92 > 79 characters)
Line 135:11: E221 multiple spaces before operator
Line 135:49: E231 missing whitespace after ','
Line 135:80: E501 line too long (92 > 79 characters)
Line 137:27: E201 whitespace after '['
Line 138:25: E201 whitespace after '['
Line 153:1: E302 expected 2 blank lines, found 1
Line 160:1: E302 expected 2 blank lines, found 1
Line 164:1: E302 expected 2 blank lines, found 1
Line 166:49: E231 missing whitespace after ','
Line 168:5: E265 block comment should start with '# '
Line 173:80: E501 line too long (93 > 79 characters)
Line 177:9: E221 multiple spaces before operator
Line 178:8: E221 multiple spaces before operator
Line 180:8: E221 multiple spaces before operator
Line 181:7: E221 multiple spaces before operator
Line 182:10: E221 multiple spaces before operator
Line 186:80: E501 line too long (124 > 79 characters)
Line 187:37: E221 multiple spaces before operator
Line 187:80: E501 line too long (110 > 79 characters)
Line 191:14: E221 multiple spaces before operator
Line 201:43: E202 whitespace before ']'
Line 202:18: E221 multiple spaces before operator
Line 208:11: E131 continuation line unaligned for hanging indent
Line 215:29: E127 continuation line over-indented for visual indent
Line 216:29: E127 continuation line over-indented for visual indent
Line 216:80: E501 line too long (82 > 79 characters)
Line 217:29: E127 continuation line over-indented for visual indent
Line 218:29: E127 continuation line over-indented for visual indent
Line 218:35: E251 unexpected spaces around keyword / parameter equals
Line 218:37: E251 unexpected spaces around keyword / parameter equals
Line 219:29: E127 continuation line over-indented for visual indent
Line 221:23: E221 multiple spaces before operator
Line 221:50: E203 whitespace before ':'
Line 221:52: E202 whitespace before ']'
Line 222:22: E221 multiple spaces before operator
Line 222:50: E203 whitespace before ':'
Line 223:50: E203 whitespace before ':'
Line 224:80: E501 line too long (99 > 79 characters)
Line 232:10: E221 multiple spaces before operator
Line 232:29: E202 whitespace before ')'
Line 233:9: E221 multiple spaces before operator
Line 233:29: E202 whitespace before ')'
Line 234:8: E221 multiple spaces before operator
Line 234:29: E202 whitespace before ')'
Line 235:8: E221 multiple spaces before operator
Line 235:29: E202 whitespace before ')'
Line 238:1: E302 expected 2 blank lines, found 1
Line 243:18: E221 multiple spaces before operator
Line 243:80: E501 line too long (80 > 79 characters)
Line 244:41: E202 whitespace before ')'
Line 245:19: E221 multiple spaces before operator
Line 245:41: E202 whitespace before ')'
Line 246:19: E221 multiple spaces before operator
Line 246:41: E202 whitespace before ')'
Line 248:37: E222 multiple spaces after operator
Line 250:20: E221 multiple spaces before operator
Line 251:20: E221 multiple spaces before operator
Line 252:20: E221 multiple spaces before operator
Line 254:20: E221 multiple spaces before operator
Line 255:20: E221 multiple spaces before operator
Line 256:20: E221 multiple spaces before operator
Line 263:17: E221 multiple spaces before operator
Line 263:80: E501 line too long (83 > 79 characters)
Line 265:16: E221 multiple spaces before operator
Line 265:80: E501 line too long (87 > 79 characters)
Line 267:15: E221 multiple spaces before operator
Line 268:19: E225 missing whitespace around operator
Line 268:33: E211 whitespace before '['
Line 271:26: E225 missing whitespace around operator
Line 274:15: E221 multiple spaces before operator
Line 275:19: E225 missing whitespace around operator
Line 275:33: E211 whitespace before '['
Line 279:15: E221 multiple spaces before operator
Line 279:80: E501 line too long (100 > 79 characters)
Line 280:15: E221 multiple spaces before operator
Line 280:80: E501 line too long (100 > 79 characters)
Line 281:80: E501 line too long (101 > 79 characters)
Line 284:13: E303 too many blank lines (2)
Line 284:16: E221 multiple spaces before operator
Line 285:15: E221 multiple spaces before operator
Line 286:15: E221 multiple spaces before operator
Line 289:15: E221 multiple spaces before operator
Line 292:15: E221 multiple spaces before operator
Line 300:80: E501 line too long (128 > 79 characters)
Line 302:50: E231 missing whitespace after ','
Line 303:38: E221 multiple spaces before operator
Line 303:45: E211 whitespace before '['
Line 303:50: E231 missing whitespace after ','
Line 304:38: E221 multiple spaces before operator
Line 304:45: E211 whitespace before '['
Line 304:50: E231 missing whitespace after ','
Line 307:43: E221 multiple spaces before operator
Line 307:51: E231 missing whitespace after ','
Line 308:43: E221 multiple spaces before operator
Line 308:51: E231 missing whitespace after ','
Line 309:43: E221 multiple spaces before operator
Line 309:51: E231 missing whitespace after ','
Line 310:43: E221 multiple spaces before operator
Line 310:51: E231 missing whitespace after ','
Line 311:43: E221 multiple spaces before operator
Line 311:51: E231 missing whitespace after ','
Line 312:43: E221 multiple spaces before operator
Line 312:51: E231 missing whitespace after ','
Line 317:18: E221 multiple spaces before operator
Line 317:80: E501 line too long (80 > 79 characters)
Line 318:41: E202 whitespace before ')'
Line 319:19: E221 multiple spaces before operator
Line 319:41: E202 whitespace before ')'
Line 320:19: E221 multiple spaces before operator
Line 320:41: E202 whitespace before ')'
Line 322:37: E222 multiple spaces after operator
Line 324:20: E221 multiple spaces before operator
Line 325:20: E221 multiple spaces before operator
Line 326:20: E221 multiple spaces before operator
Line 328:20: E221 multiple spaces before operator
Line 329:20: E221 multiple spaces before operator
Line 330:20: E221 multiple spaces before operator
Line 333:9: E303 too many blank lines (2)
Line 336:80: E501 line too long (86 > 79 characters)
Line 337:17: E221 multiple spaces before operator
Line 337:80: E501 line too long (83 > 79 characters)
Line 338:16: E221 multiple spaces before operator
Line 338:80: E501 line too long (88 > 79 characters)
Line 338:87: E202 whitespace before ']'
Line 340:15: E221 multiple spaces before operator
Line 340:79: E202 whitespace before ']'
Line 340:80: E501 line too long (80 > 79 characters)
Line 341:19: E225 missing whitespace around operator
Line 341:33: E211 whitespace before '['
Line 341:79: E202 whitespace before ']'
Line 341:80: E501 line too long (80 > 79 characters)
Line 344:26: E225 missing whitespace around operator
Line 347:15: E221 multiple spaces before operator
Line 347:79: E202 whitespace before ']'
Line 347:80: E501 line too long (80 > 79 characters)
Line 348:19: E225 missing whitespace around operator
Line 348:33: E211 whitespace before '['
Line 348:79: E202 whitespace before ']'
Line 348:80: E501 line too long (80 > 79 characters)
Line 352:15: E221 multiple spaces before operator
Line 352:80: E501 line too long (101 > 79 characters)
Line 352:100: E202 whitespace before ']'
Line 353:15: E221 multiple spaces before operator
Line 353:80: E501 line too long (101 > 79 characters)
Line 353:100: E202 whitespace before ']'
Line 354:80: E501 line too long (102 > 79 characters)
Line 354:101: E202 whitespace before ']'
Line 361:80: E501 line too long (128 > 79 characters)
Line 364:38: E221 multiple spaces before operator
Line 365:38: E221 multiple spaces before operator
Line 368:43: E221 multiple spaces before operator
Line 368:51: E231 missing whitespace after ','
Line 369:43: E221 multiple spaces before operator
Line 369:51: E231 missing whitespace after ','
Line 370:43: E221 multiple spaces before operator
Line 370:51: E231 missing whitespace after ','
Line 371:43: E221 multiple spaces before operator
Line 371:51: E231 missing whitespace after ','
Line 372:43: E221 multiple spaces before operator
Line 372:51: E231 missing whitespace after ','
Line 373:43: E221 multiple spaces before operator
Line 373:51: E231 missing whitespace after ','
Line 374:80: E501 line too long (133 > 79 characters)
Line 376:1: E302 expected 2 blank lines, found 1
Line 379:80: E501 line too long (118 > 79 characters)
Line 384:42: E201 whitespace after '('
Line 384:48: E202 whitespace before ')'
Line 388:1: E302 expected 2 blank lines, found 1
Line 391:80: E501 line too long (118 > 79 characters)
Line 396:42: E201 whitespace after '('
Line 396:48: E202 whitespace before ')'
Line 402:1: E303 too many blank lines (3)
Line 406:80: E501 line too long (110 > 79 characters)
Line 406:101: E203 whitespace before ','
Line 406:102: E231 missing whitespace after ','
Line 409:20: E221 multiple spaces before operator
Line 410:20: E221 multiple spaces before operator
Line 412:22: E221 multiple spaces before operator
Line 413:20: E221 multiple spaces before operator
Line 414:22: E221 multiple spaces before operator
Line 415:20: E221 multiple spaces before operator
Line 420:80: E501 line too long (98 > 79 characters)
Line 421:14: E221 multiple spaces before operator
Line 421:80: E501 line too long (109 > 79 characters)
Line 424:9: E122 continuation line missing indentation or outdented
Line 425:9: E122 continuation line missing indentation or outdented
Line 425:80: E501 line too long (122 > 79 characters)
Line 427:58: E228 missing whitespace around modulo operator
Line 430:80: E501 line too long (279 > 79 characters)
Line 432:80: E501 line too long (112 > 79 characters)
Line 434:16: E221 multiple spaces before operator
Line 435:16: E221 multiple spaces before operator
Line 460:80: E501 line too long (81 > 79 characters)
Line 470:80: E501 line too long (110 > 79 characters)
Line 473:80: E501 line too long (88 > 79 characters)
Line 484:80: E501 line too long (110 > 79 characters)
Line 489:5: E303 too many blank lines (4)
Line 490:1: W391 blank line at end of file

Line 58:1: E302 expected 2 blank lines, found 1
Line 62:16: E203 whitespace before ':'
Line 64:26: E203 whitespace before ':'
Line 69:1: E302 expected 2 blank lines, found 1
Line 81:16: E203 whitespace before ':'
Line 83:26: E203 whitespace before ':'
Line 88:5: E265 block comment should start with '# '
Line 93:10: E261 at least two spaces before inline comment
Line 93:10: E262 inline comment should start with '# '
Line 128:42: E261 at least two spaces before inline comment
Line 129:43: E261 at least two spaces before inline comment
Line 159:26: E203 whitespace before ':'
Line 162:22: E203 whitespace before ':'
Line 166:20: E203 whitespace before ':'

Line 13:15: E251 unexpected spaces around keyword / parameter equals
Line 13:17: E251 unexpected spaces around keyword / parameter equals
Line 13:26: E203 whitespace before ','
Line 13:80: E501 line too long (92 > 79 characters)

timspainUCL
timspainUCL suggested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@timspainUCL timspainUCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through all the solver maths or the GDAL reprojection, so I assume these work as intended

kaska/kaska_sar.py Outdated
@@ -1,149 +1,490 @@
# -*- coding: utf-8 -*-
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the shebang needed? The module doesn't contain any executable code any more.

kaska/inference_runner.py Outdated
s1_obs = copy.copy(config.s1_obs)
s1_obs.apply_roi(ulx, uly, lrx, lry)

s1_inversion = KasKASAR(config.temporal_grid, config.state_mask,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check capitalization.

@jgomezdans
Copy link
Collaborator

This should be merged in branch sar_quick, not master

@dpshelio dpshelio changed the base branch from master to sar_quick February 19, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timspainUCL timspainUCL timspainUCL requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@McWhity @pep8speaks @jgomezdans @timspainUCL