Sensible logging #53
Merged
Sensible logging #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 6, 2019 13:06
I have now added logging both to a file and console. The code is consistent for all submodules. It's spitting things twice to the console, so there's some issue in adding handlers, but other than that, it appears to be working OK. There are lots of changes to all files, but basically most of them are just simplifying things.
dpshelio
approved these changes
Sep 11, 2019
Co-Authored-By: David Pérez-Suárez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5
Addresses #38
Addresses #33
OK, so I added some logging infrastructure to the entire codebase. As far as I can see, it works as advertised, other than the console logger outputs stuff twice. I haven't been able to trap what causes that (e.g. adding an extra handler but I can't see anywhere this is done).
There's some extra flexibility one may want to have (e.g. set the level via a
verboseflag), but that's a cosmetic change.