[FIX] sap.m.IllustrationPool: gracefully remove DOM pool assets #4309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup
_removeAssetFromDOMPool
starts3.1.
oDOMPool
(a "static" DOM element) exists3.2.
oAssetDOM
(the thing we presumably no longer need and want to remove) exists_removeAssetFromDOMPool
will silently do nothing (it will leaveaSymbolsInDOM
intact)Some semantics
In my case,
oAssetDOM
was being removed dynamically, by some other application code.Leaving the question whether this element should be removed by some other application code aside, it seems to me the symbol removal should not be tied to the DOM element removal, unless I have missed some other dependency.
In any case, "get your app frozen if you remove the wrong DOM element" feels weird so I decided to check for second opinion by opening this PR.