fix(AnalyticalTable): fix vertical scrollbar styles for Chromium browsers & Firefox #7839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +879 B (+0.2%) Total Size: 448 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 18653716633Details
💛 - Coveralls |
| { | ||
| className, | ||
| className: clsx( | ||
| cellProps.className, |
There was a problem hiding this comment.
className from cell props was not added previously, could that cause issues?
There was a problem hiding this comment.
This shouldn’t change how things work right now, since plugin hooks run in the order they’re added. I added it mainly for consistency - if we ever add another hook before useStyling that also uses className, its classes would otherwise get overwritten.
packages/main/src/components/AnalyticalTable/scrollbars/VerticalScrollbar.tsx
Show resolved
Hide resolved
Lukas742
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome:
Here the table is scrolled to the last row
Solution: force reflow to update scrollbar track height
Firefox:
widthis set.Solution: Use native scrollbar and add padding in last cells to prevent content from being hidden
General: