Skip to content

fix(ui5-toolbar): prevent flickering on item state changes #12222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-toolbar): prevent flickering on item state changes #12222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/main/src/Toolbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ class Toolbar extends UI5Element {

/**
* Defines the items of the component.
*
* **Note:** Currently only `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` are allowed here.
*
* **Note:** Currently only `ui5-toolbar-button`, `ui5-toolbar-select`, `ui5-toolbar-separator` and `ui5-toolbar-spacer` are allowed here.
* @public
*/
@slot({
Expand Down Expand Up @@ -281,8 +281,11 @@ class Toolbar extends UI5Element {
}

onInvalidation(changeInfo: ChangeInfo) {
if (changeInfo.reason === "childchange" && changeInfo.child === this.itemsToOverflow[0]) {
this.onToolbarItemChange();
if (changeInfo.reason === "childchange") {
const currentItemsWidth = this.items.reduce((total, item) => total + this.getItemWidth(item), 0);
if (currentItemsWidth !== this.itemsWidth) {
this.onToolbarItemChange();
}
}
}

Expand All @@ -301,7 +304,7 @@ class Toolbar extends UI5Element {
this.storeItemsWidth();
this.processOverflowLayout();
this.items.forEach(item => {
item.isOverflowed = this.overflowItems.map(overflowItem => overflowItem).indexOf(item) !== -1;
item.isOverflowed = this.overflowItems.map(overflowItem => overflowItem).indexOf(item) !== -1;
});
}

Expand Down
Loading