fix(ui5-date-picker): add input CSS part for styling #12559
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input CSS part to DatePicker and TimePicker components to allow styling of the native input element using ::part(input) selector. - Add @csspart input documentation for both components - Forward part attribute to DateTimeInput in templates - Maintains consistency with ui5-input component API - Enables scoping-friendly styling without deep selectors Enhanced accessibility and styling capabilities following UI5 Web Components Definition of Done guidelines.
unazko
changed the title
nnaydenow
reviewed
Oct 28, 2025
packages/main/src/DatePicker.ts
Outdated
| * @constructor | ||
| * @extends DateComponentBase | ||
| * @public | ||
| * @csspart input - Used to style the native input element |
There was a problem hiding this comment.
it's not native input element
There was a problem hiding this comment.
We are going through an abstraction (ui5-input element), in order to style the native input element in this case, which is the final goal.
Here is what we've received with this csspart approach of documentation (end goal in mind first):
Pros:
- Matches user intent - they want to style the input field
- Consistent with how other CSS parts are documented (focus on what gets styled)
- Simpler mental model for developers
- Aligns with the Input component's own documentation: "Used to style the native input element"
Cons:
- Slightly abstracts the forwarding mechanism
|
🚀 Deployed on https://pr-12559--ui5-webcomponents-preview.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input CSS part to DatePicker and TimePicker components to allow styling of the native input element using ::part(input) selector.