fix(ui5-dynamic-page-title): correct ARIA attribute handling for non-interactive titles #12598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interactive titles When the DynamicPageTitle is non-interactive, the ARIA labelledby attribute should not reference any heading elements. This change ensures that the _ariaLabelledBy getter returns undefined when the title is not interactive, preventing potential accessibility issues. Fixes: #12466
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12598--ui5-webcomponents.netlify.app |
plamenivanov91
approved these changes
Nov 7, 2025
plamenivanov91
pushed a commit
to plamenivanov91/ui5-webcomponents
that referenced
this pull request
Nov 7, 2025
…interactive titles (UI5#12598) When the DynamicPageTitle is non-interactive, the ARIA labelledby attribute should not reference any heading elements. This change ensures that the _ariaLabelledBy getter returns undefined when the title is not interactive, preventing potential accessibility issues. Fixes: UI5#12466
Collaborator
|
🎉 This PR is included in version v2.17.0-rc.1 🎉 The release is available on v2.17.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DynamicPageTitle is non-interactive, the ARIA labelledby attribute should not reference any heading elements. This change ensures that the _ariaLabelledBy getter returns undefined when the title is not interactive, preventing potential accessibility issues.
Fixes: #12466