Fix Inspect View showing stale sample data#3325
Merged
dragonstyle merged 2 commits intoUKGovernmentBEIS:mainfrom Feb 27, 2026
Merged
Fix Inspect View showing stale sample data#3325dragonstyle merged 2 commits intoUKGovernmentBEIS:mainfrom
dragonstyle merged 2 commits intoUKGovernmentBEIS:mainfrom
Conversation
rasmusfaber
force-pushed
the
faber/fix-stale-sample-display
branch
from
27cfa31 to
74f0e84
Compare
5 tasks
Collaborator
|
@rasmusfaber I can't resolve the conflict on the branch, but when you do ping me and I will merge it ASAP to avoid piling up more conflicts. |
When clicking between samples quickly, the previous sample's API response could arrive after the new sample started loading, overwriting the correct data. Fix with three changes: - Add generation counter to invalidate in-flight responses from previous loads - Consolidate three separate state updates into atomic prepareForSampleLoad() - Fix render guard to not display content while loading or when sample doesn't match the requested ID Co-Authored-By: Claude Opus 4.6 <[email protected]>
rasmusfaber
force-pushed
the
faber/fix-stale-sample-display
branch
from
74f0e84 to
c5feaea
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
rasmusfaber
force-pushed
the
faber/fix-stale-sample-display
branch
from
c5feaea to
1be8d9c
Compare
Contributor
Author
@dragonstyle Done. |
5 tasks
Contributor
|
Life-changing for large samples! Thanks so much @rasmusfaber |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
When navigating between samples in Inspect View, the previous sample is shown until the new sample has been loaded, which can be confusing.
What is the new behavior?
Three fixes prevent stale sample display:
prepareForSampleLoad) instead of three separate callsDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
Extracted from #3214