Conversation
swoo0514
reviewed
Dec 2, 2024
Collaborator
There was a problem hiding this comment.
구조적으로 잘 짜여진 것 같아요. 하지만 callback uri를 하드코딩하기보다는 환경변수로 관리하는 것이 더 좋아보입니다!
swoo0514
reviewed
Dec 2, 2024
Collaborator
There was a problem hiding this comment.
tyr-catch문을 적극적으로 사용하셔도 좋을 것 같아요!
swoo0514
approved these changes
Dec 2, 2024
Collaborator
swoo0514
left a comment
swoo0514
left a comment
There was a problem hiding this comment.
comment만 확인하시고 수정하시면 될 듯 합니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
카카오 로그인 연동