Skip to content

✨ [FEAT] #127: 스페이스 탭 프리뷰 제거 & 메인 온보딩 화면 수정#133

Merged
SuHyeon00 merged 18 commits intodevelopfrom
feature/#127-remove-preview-and-add-onboarding
Jan 4, 2026
Merged

✨ [FEAT] #127: 스페이스 탭 프리뷰 제거 & 메인 온보딩 화면 수정#133
SuHyeon00 merged 18 commits intodevelopfrom
feature/#127-remove-preview-and-add-onboarding

Conversation

@SuHyeon00
Copy link
Contributor

@SuHyeon00 SuHyeon00 commented Dec 28, 2025

#⃣ 연관된 이슈

📝 작업 내용

  • 스페이스 탭 확대시 버블 프리뷰 제거
  • 라벨탭 온보딩 메인 온보딩 플로우에 추가
  • 버블 입력창 온보딩 추가
  • 라벨 상세페이지 온보딩 추가

📸 스크린샷 (선택)

Screen_recording_20251228_165846.mp4

Note

Adds cohesive onboarding flows across key screens with position-tracking and dismissal persistence.

  • Bubble Input: new BubbleInputOnboardingState, stepper (label → link → link menu), toolbar reports bounds; BubbleInputOnboardingScreen guides and persists via Get/SetHasSeenOnboarding.
  • Label List: onboarding enhanced with draggable highlight (draggedIndex), optional temporary label injection when empty, and cleanup on dismiss.
  • Label Detail: onboarding with bubble long-press guidance; injects temporary example bubbles when empty and removes them on dismiss.
  • Space (graph): onboarding for keyword-map FAB; BubbleGraphScreen switches to tap-on-dot interaction, removes zoomed previews, centralizes dot radius (BUBBLE_DOT_RADIUS).
  • My Edison: onboarding flow expanded (storage and label tabs), uses image placeholders during onboarding.
  • UI infrastructure: reusable ButtonOnboarding + OnboardingConstants; rename BubbleStorageOnboarding to BubbleSpaceOnboarding; toolbar/popups expose bounds for onboarding; small perf fix in isOverlapping (squared distance).

Written by Cursor Bugbot for commit dbe60a5. This will update automatically on new commits. Configure here.

@SuHyeon00 SuHyeon00 self-assigned this Dec 28, 2025
@SuHyeon00 SuHyeon00 added ♻️ refactor Improvements or additions to documentation ✨ feature New feature or request labels Dec 28, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SuHyeon00, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 주요 기능에 대한 새로운 온보딩 경험을 도입하여 사용자 온보딩 프로세스를 크게 개선합니다. 버블 입력, 라벨 관리, 라벨 상세 페이지에 대한 가이드 투어가 추가되었으며, 기존 메인 온보딩 흐름에 통합되었습니다. 또한, 스페이스 탭의 버블 프리뷰 기능을 제거하여 인터페이스를 간소화하고, 온보딩 UI 컴포넌트를 재사용 가능하도록 리팩토링하여 전반적인 사용자 안내를 더욱 명확하고 효율적으로 만들었습니다.

Highlights

  • 온보딩 기능 확장: 버블 입력창, 라벨 탭, 라벨 상세 페이지에 대한 새로운 온보딩 플로우가 추가되어 사용자 경험을 향상시켰습니다.
  • 메인 온보딩 플로우 업데이트: 메인 온보딩 흐름이 수정되어 새로 추가된 라벨 탭 온보딩을 포함하도록 변경되었습니다.
  • 스페이스 탭 프리뷰 제거: 스페이스 탭 확대 시 버블 프리뷰 기능이 제거되어 화면 복잡성을 줄였습니다.
  • 온보딩 UI/UX 개선: 재사용 가능한 온보딩 컴포넌트(ButtonOnboarding.kt, OnboardingConstants.kt)를 도입하여 온보딩 화면의 일관성과 개발 효율성을 높였습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 앱의 여러 화면에 걸쳐 온보딩 플로우를 도입하고 관련 UI를 리팩토링하는 중요한 변경 사항을 담고 있습니다. 전반적으로 재사용 가능한 ButtonOnboarding 컴포저블을 도입하고, OnboardingConstants를 통해 매직 넘버를 제거하는 등 코드 품질을 높이기 위한 좋은 시도들이 돋보입니다.

몇 가지 개선점을 제안합니다:

  • BubbleInputViewModel에서 상태 전환 로직의 가독성을 높이는 리팩토링
  • BubbleInputOnboardingScreen에서 UI 위치 계산 로직을 더 안정적으로 개선
  • BubbleGraphScreen에서 하드코딩된 값을 상수로 추출하여 유지보수성 향상

자세한 내용은 각 파일의 리뷰 코멘트를 참고해주세요.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@cursor
Copy link

cursor bot commented Dec 28, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link
Contributor

@ally010314 ally010314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 작동하는것 확인했습니다! 수고많으셨어요

Copy link
Contributor

@HwangJaemin49 HwangJaemin49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

온보딩, 버블 스페이스에서 버블 클릭 시 해당 버블로 넘어가는 거 확인 완료했습니다!

@SuHyeon00 SuHyeon00 merged commit a372d31 into develop Jan 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ refactor Improvements or additions to documentation ✨ feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [FEAT] 스페이스 뷰 버블 프리뷰 제거 & 온보딩 화면 마무리

3 participants