Skip to content

Conversation

@rohan-ap457
Copy link

@rohan-ap457 rohan-ap457 commented Dec 4, 2024

Overview of Changes

General overview of what has been changed

falco in progress not tested ripped from notes.

Reason for Modification

This section will list the reasons modification were preformed. This justifies why the changes are necessary or the documentation should be added.

Verification

  • The documentation is completed, or does not contain work-in-progress/partially-completed sections.
  • The documentation is written in Markdown (Exception for Inject and Incident Reports).
  • Any Images are contained in a subdirectory Images.
  • Any scripts, Ansible Playbooks, Terraform scripts, etc. Have documentation explaining their purpose and use case.
  • Any scripts are tested.
  • I have assigned and notified a reviewer.

@rohan-ap457 rohan-ap457 requested a review from a team as a code owner December 4, 2024 00:00
Copy link
Contributor

@ChrisM09 ChrisM09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few major things that need to be done:

  1. Must be tested on both a standalone system and a working K8s cluster. Otherwise, it could cause a lot of confusion.
  2. A description on what Falco is needed. Link to another README that does this as well.
  3. No description on how to use these Ansible playbooks on a system.
  4. Any considerations when deploying this?
  5. Use code blocks for quick copy and pasting.

There are more, but you get the point.

made bash scripts from the yaml's and these didnt not break the graylog test machines. will have to test on other systems and services
viktor dashboard
Copy link
Contributor

@DaintyJet DaintyJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You put the bash scripts into the ansible folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants