-
Couldn't load subscription status.
- Fork 7
Terraform #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decent start, there are some formatting issues and sections should probably be re-worded or additional info added.
| * Audit the DNS Server each machine is configured to use (/etc/resolv.conf, nmtui) | ||
| * Can Wazuh do this? What about Zabbix | ||
| * Is DNSSec something that is good | ||
| * Question(Need to look into): Is DNSSec something that is good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to separate out any cleanup things like this into a separate pull request just to make sure things are more streamlined and clean. Its fine for this one, but something to keep in mind for the future.
I do this type of thing too. I am trying to get better...
| @@ -0,0 +1,93 @@ | |||
| # About | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to make the title of the document more descriptive with the following section being an implicit about section for the document.
| @@ -0,0 +1,93 @@ | |||
| # About | |||
| This a helpfile listing the components used in the creation of a teraform based infrastructure. This uses aws-provider based examples, but are general to any terraform provider. This is organized into 2 groups, components & files. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different from the name of the document, which includes help-commands where it is more of an broader introduction?
Also Terraform is spelled incorrectly and should be capitalized.
| # About | ||
| This a helpfile listing the components used in the creation of a teraform based infrastructure. This uses aws-provider based examples, but are general to any terraform provider. This is organized into 2 groups, components & files. | ||
|
|
||
| *Of course, this is not every single aspect of terraform, but should be a decent start to creating a full terraform-based infrastructure* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| *Of course, this is not every single aspect of terraform, but should be a decent start to creating a full terraform-based infrastructure* | |
| > [!NOTE] | |
| > This is not every aspect of terraform, but should provide a decent starting point in the creation of a full terraform-based infrastructure |
|
|
||
|
|
||
| ## Components | ||
| ### Providers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some sections have the : while others do not. I prefer not using them vs using them.
|
|
||
| Create a main.tf file. Convention is to name the file "main.tf" | ||
|
|
||
| This is where the block of the cofiguration for the virtual machines will be deployed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This is where the block of the cofiguration for the virtual machines will be deployed | |
| This is where the block of the configuration for the virtual machines will be deployed |
| ``` | ||
|
|
||
| ## Initialize Terraform | ||
| 1. Intialize terraform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Intialize terraform | |
| 1. Initialize terraform |
| ## Delete resources using terraform destroy | ||
| ```sh | ||
| terraform destory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think destroy is spelled wrong
| Show issues regarding your terraform file | ||
|
|
||
| ```sh | ||
| terraform plan` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra `?
| ``` | ||
|
|
||
|
|
||
| ## Run terraform plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is tabbed in too much making it into a code block
Overview of Changes
General overview of what has been changed
Reason for Modification
This section will list the reasons modification were preformed. This justifies why the changes are necessary or the documentation should be added.
Verification
Images.