Skip to content

Conversation

@rohan-ap457
Copy link

@rohan-ap457 rohan-ap457 commented Oct 8, 2024

Overview of Changes

General overview of what has been changed

redid the k8s simple guide and made it into markdown from latex and fixed commands that didnt work or were cut off completely 

[kubernetes_installation_with_flannel_as_cni.md](https://github.com/user-attachments/files/17296231/kubernetes_installation_with_flannel_as_cni.md)

https://github.com/user-attachments/files/17296231/kubernetes_installation_with_flannel_as_cni.md

Reason for Modification

This section will list the reasons modification were preformed. This justifies why the changes are necessary or the documentation should be added.

Verification

  • The documentation is completed, or does not contain work-in-progress/partially-completed sections.
  • The documentation is written in Markdown (Exception for Inject and Incident Reports).
  • Any Images are contained in a subdirectory Images.
  • Any scripts, Ansible Playbooks, Terraform scripts, etc. Have documentation explaining their purpose and use case.
  • Any scripts are tested.
  • I have assigned and notified a reviewer.

@rohan-ap457 rohan-ap457 requested a review from a team as a code owner October 8, 2024 16:12
@rohan-ap457 rohan-ap457 changed the title Rohan ap457 patch 1 k8s simple install guide Oct 8, 2024
Copy link
Contributor

@DaintyJet DaintyJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only file that is included in the commit is the old PDF.

Copy link
Author

@rohan-ap457 rohan-ap457 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@DaintyJet DaintyJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old PDF should probably be deleted.

Also the new Markdown should be placed into the K8s folder.

On your branch this would be: https://github.com/UML-Cyber-Security/CCDC_Practice_Infrastructure/tree/rohan-ap457-patch-1/OperatingSystem-Services/Service-Containers/Kubernetes

@DaintyJet
Copy link
Contributor

Otherwise seemed fine to me. Chris likes Images but I am fine with, or without.

…mple_installtion_wiht_flannel_as_cni.pdf

deleted this
…tem-Services/Service-Containers/Kubernetes/kubernetes_installation_with_flannel_as_cni.md

updated location of file
@rohan-ap457
Copy link
Author

rohan-ap457 commented Oct 8, 2024

done all except images

Copy link
Contributor

@DaintyJet DaintyJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Enough For me. I think @P-rple should take a look.

@DaintyJet DaintyJet requested a review from P-rple October 11, 2024 16:50
@P-rple
Copy link
Contributor

P-rple commented Oct 14, 2024

Are there supposed to be images @rohan-ap457 , if so, I don't see any.

@rohan-ap457
Copy link
Author

i did not have an screenshots to go with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants