Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] add tests for the ToDoList class #18

Merged
merged 4 commits into from
Mar 3, 2025
Merged

[test] add tests for the ToDoList class #18

merged 4 commits into from
Mar 3, 2025

Conversation

brnorris03
Copy link
Contributor

@brnorris03 brnorris03 commented Feb 26, 2025 •
edited
Loading

This patch adds unit tests for the todo.ToDoList class

@Zornack Zornack self-requested a review February 26, 2025 22:49
@brnorris03 brnorris03 marked this pull request as ready for review March 3, 2025 19:48
@lameybelle lameybelle self-requested a review March 3, 2025 22:04
@DylanGutierrezUO DylanGutierrezUO self-requested a review March 3, 2025 22:04
hazelmeow
hazelmeow approved these changes Mar 3, 2025
View reviewed changes
Copy link

@hazelmeow hazelmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SeanLear SeanLear self-requested a review March 3, 2025 22:05
lameybelle
lameybelle approved these changes Mar 3, 2025
View reviewed changes
Copy link

@lameybelle lameybelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! super useful, no additions

NLaureano
NLaureano approved these changes Mar 3, 2025
View reviewed changes
Copy link

@NLaureano NLaureano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks epic-sauce!

@emilede emilede self-requested a review March 3, 2025 22:06
@SeanLear
Copy link

SeanLear commented Mar 3, 2025

Looks great.

Akminar
Akminar approved these changes Mar 3, 2025
View reviewed changes
Copy link

@Akminar Akminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks lovely, thanks :)

michaelcUO
michaelcUO approved these changes Mar 3, 2025
View reviewed changes
Copy link

@michaelcUO michaelcUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

emilede
emilede approved these changes Mar 3, 2025
View reviewed changes
Copy link

@emilede emilede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good descriptive test names, approved.

sshina
sshina approved these changes Mar 3, 2025
View reviewed changes
Copy link

@sshina sshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test cases. I like that you've automated the process with ci_for_todo.yml

DylanGutierrezUO
DylanGutierrezUO approved these changes Mar 3, 2025
View reviewed changes
Copy link

@DylanGutierrezUO DylanGutierrezUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to read and understand. Approved!

anmaiiii
anmaiiii approved these changes Mar 3, 2025
View reviewed changes
Copy link

@anmaiiii anmaiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CharlieHudson31
CharlieHudson31 reviewed Mar 3, 2025
View reviewed changes
Copy link

@CharlieHudson31 CharlieHudson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@brnorris03 brnorris03 merged commit 52fc13e into main Mar 3, 2025
2 checks passed
@brnorris03 brnorris03 deleted the boyana/todo_tests branch March 3, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieHudson31 CharlieHudson31 CharlieHudson31 left review comments

@hazelmeow hazelmeow hazelmeow approved these changes

@NLaureano NLaureano NLaureano approved these changes

@SeanLear SeanLear SeanLear approved these changes

@sshina sshina sshina approved these changes

@lameybelle lameybelle lameybelle approved these changes

@Akminar Akminar Akminar approved these changes

@emilede emilede emilede approved these changes

@anmaiiii anmaiiii anmaiiii approved these changes

@DylanGutierrezUO DylanGutierrezUO DylanGutierrezUO approved these changes

@michaelcUO michaelcUO michaelcUO approved these changes

@Zornack Zornack Awaiting requested review from Zornack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.