Feature/dam profile chart - #253
Open
thill02 wants to merge 7 commits into
Open
Conversation
krowvin
requested changes
Jun 4, 2026
Contributor
There was a problem hiding this comment.
Made some suggestion fixes for you from our previous voice conversation.
Open to discussing A2W naming, we could also attribute the graphic to A2W on the page and/or mention that was the source of it? I'm just suggesting we don't name components with it if it does not pull data from that source. (I think I got them all?)
Also wondering if we should go ahead and make a "Graphics" menu / dropdown for link navigation?
krowvin
self-requested a review
June 4, 2026 17:16
krowvin
requested changes
Jun 30, 2026
krowvin
left a comment
krowvin
left a comment
Contributor
There was a problem hiding this comment.
I'm seeing unresolved conversations on A2W, were we wanting to leave those in?
As well there's some suggested code changes that do not appear to be merged.
Might comment/reply on those if you have thoughts!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.