Use Groundwork 4 in docs - #324
Open
krowvin wants to merge 1 commit into
Open
Conversation
krowvin
marked this pull request as ready for review
August 19, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Do not merge this PR until USACE/groundwork#300 is merged and its fix is published in a new Groundwork 4.x release.
After that release, refresh this lockfile so CI resolves the fixed version instead of the currently published 4.3.1.
Summary
@usace/groundwork@^3.14.19to the supported^4.0.0peer rangeWhy
Groundwork Water already declares support for
@usace/groundwork "^3.14.19 || ^4.0.0", but the docs remain locked to Groundwork 3.x. That leaves the supported 4.x integration unexercised by the docs and CI.The currently published Groundwork 4.3.1 ESM bundle still contains the browser-breaking React
require()fallback addressed by USACE/groundwork#300, so this PR must remain blocked until the upstream fix is released.Validation
npx vitest run --maxWorkers=1— 12 files and 44 tests passednpm run build-lib1c1533096cab4486b42fd980683ea764f0b8c775:npm run verify-libpassednpm run check-changeset