Skip to content

Use Groundwork 4 in docs - #324

Open
krowvin wants to merge 1 commit into
mainfrom
chore/docs-groundwork-4
Open

Use Groundwork 4 in docs#324
krowvin wants to merge 1 commit into
mainfrom
chore/docs-groundwork-4

Conversation

@krowvin

@krowvin krowvin commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Do not merge this PR until USACE/groundwork#300 is merged and its fix is published in a new Groundwork 4.x release.

After that release, refresh this lockfile so CI resolves the fixed version instead of the currently published 4.3.1.

Summary

  • update the docs dependency from @usace/groundwork@^3.14.19 to the supported ^4.0.0 peer range
  • update the docs lockfile to exercise Groundwork 4.x in docs builds and React compatibility CI
  • add an empty changeset because this docs-only dependency update does not require a Groundwork Water release

Why

Groundwork Water already declares support for @usace/groundwork "^3.14.19 || ^4.0.0", but the docs remain locked to Groundwork 3.x. That leaves the supported 4.x integration unexercised by the docs and CI.

The currently published Groundwork 4.3.1 ESM bundle still contains the browser-breaking React require() fallback addressed by USACE/groundwork#300, so this PR must remain blocked until the upstream fix is released.

Validation

  • npx vitest run --maxWorkers=1 — 12 files and 44 tests passed
  • npm run build-lib
  • production docs build with the local Groundwork Water package and published Groundwork 4.3.1
  • exact upstream PR Bump jsdom from 26.1.0 to 29.1.1 #300 head 1c1533096cab4486b42fd980683ea764f0b8c775:
    • npm run verify-lib passed
    • packaged and installed alongside the local Groundwork Water build
    • production docs build passed
    • verified the browser-breaking ESM fallback is absent
  • Prettier check for the changed dependency files
  • npm run check-changeset

@krowvin
krowvin requested a review from msweier August 19, 2026 14:27
@krowvin
krowvin marked this pull request as ready for review August 19, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant