Skip to content

Added filtered time series retrieval API. - #1169

Merged
rma-rripken merged 8 commits into
developfrom
feature/2088-ts-filter
Jul 25, 2025
Merged

Added filtered time series retrieval API.#1169
rma-rripken merged 8 commits into
developfrom
feature/2088-ts-filter

Conversation

@rma-rripken

Copy link
Copy Markdown
Collaborator

Introduced TimeSeriesRequestParameters and 'FilteredTimeSeriesParameters' to clean up TimeSeriesDaoImpl. Added RSQL query capability

Introduced `TimeSeriesRequestParameters` and 'FilteredTimeSeriesParameters' to clean up TimeSeriesDaoImpl.
Added RSQL query capability
@rma-rripken

Copy link
Copy Markdown
Collaborator Author

Replacement PR b/c #1158 got closed when I force-pushed a new branch that didn't have the weird self-merge in its history

@rma-rripken
rma-rripken marked this pull request as ready for review July 15, 2025 19:08
@rma-rripken

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson Last we talked you suggested merging this and letting people give feedback

@MikeNeilson

Copy link
Copy Markdown
Contributor

I was hoping some feedback would be provided on the PR, but merge and let be used is likely the more practical way at this point.

@rma-rripken

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson Should I remove the explicit min-value, max-value and filter-nulls parameters from the controller? With the filter-expression-language implemented those features can be achieved in an RSQL query. Removing them might force people to figure out how to build their query?

@MikeNeilson

Copy link
Copy Markdown
Contributor

That seems rational to me, doesn't really make sense to have both and need to support two different paths.

@rma-rripken

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson This is ready now

@rma-rripken
rma-rripken merged commit 6f3f0aa into develop Jul 25, 2025
6 checks passed
@rma-rripken
rma-rripken deleted the feature/2088-ts-filter branch July 25, 2025 15:51
rma-bryson pushed a commit that referenced this pull request Jul 29, 2025
Introduced `TimeSeriesRequestParameters` and
'FilteredTimeSeriesParameters' to clean up TimeSeriesDaoImpl. Added RSQL
query capability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Filtering Parameters for Greater Than, Less Than, and Order to Timeseries Endpoint

2 participants